Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and clean assume-role to better handle AWS STS CLI errors @jfagoagas #946

Merged
merged 4 commits into from
Dec 1, 2021

Conversation

jfagoagas
Copy link
Member

@jfagoagas jfagoagas commented Nov 28, 2021

Include a better error management for AWS STS CLI when assuming an IAM Role.

Also, the code including ROLE_EXTERNAL_ID has been simplified.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@toniblyx toniblyx changed the base branch from master to 2.7 November 29, 2021 09:57
@toniblyx toniblyx changed the title fix(assume-role): Handle AWS STS CLI errors Fix assume-role: handle AWS STS CLI errors @jfagoagas Nov 29, 2021
@toniblyx
Copy link
Member

toniblyx commented Dec 1, 2021

@jfagoagas this has some conflicts now, after merging the previous one, can you give it a look please?

@jfagoagas
Copy link
Member Author

@jfagoagas this has some conflicts now, after merging the previous one, can you give it a look please?

Done!

@toniblyx toniblyx changed the title Fix assume-role: handle AWS STS CLI errors @jfagoagas Fix and clean assume-role to better handle AWS STS CLI errors @jfagoagas Dec 1, 2021
@toniblyx toniblyx merged commit fa46709 into prowler-cloud:2.7 Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants