Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with Security Hub integration when resolving closed findings are either a lot of new findings, or a lot of resolved findings @Kirizan #953

Merged
merged 3 commits into from
Dec 3, 2021

Conversation

Kirizan
Copy link
Contributor

@Kirizan Kirizan commented Dec 1, 2021

Fixes #950

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…s. Also added a check for an edge case where if the updated findings was a multiple of the batch size, it would throw an error for attempting to import 0 findings.
@toniblyx toniblyx changed the title Fixed issue with resolving closed findings in Security Hub when there are either a lot of new findings, or a lot of resolved findings. Fix issue with Security Hub integration when resolving closed findings are either a lot of new findings, or a lot of resolved findings @Kirizan Dec 1, 2021
@toniblyx toniblyx merged commit 3c3a3f7 into prowler-cloud:2.7 Dec 3, 2021
@toniblyx
Copy link
Member

toniblyx commented Dec 3, 2021

Thanks @Kirizan this is a great improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants