Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation fails after latest ucto release #11

Closed
proycon opened this issue Dec 17, 2021 · 3 comments
Closed

Compilation fails after latest ucto release #11

proycon opened this issue Dec 17, 2021 · 3 comments
Assignees
Labels

Comments

@proycon
Copy link
Owner

proycon commented Dec 17, 2021

    gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -march=x86-64 -mtune=generic -O3 -pipe -fno-plt -march=x86-64 -mtune=generic -O3 -pipe -fno-plt -march=x86-64 -mtune=generic -O3 -pipe -fno-plt -fPIC -I/home/proycon/envs/dev
/include -I/usr/include/ -I/usr/include/libxml2 -I/usr/local/include/ -I/home/proycon/envs/dev/include -I/usr/include/python3.10 -c ucto_wrapper.cpp -o build/temp.linux-x86_64-3.10/ucto_wrapper.o --std=c++0x -D U_USING_ICU_NAMESPACE=1
    ucto_wrapper.cpp: In function ‘PyObject* __pyx_gb_4ucto_9Tokenizer_8generator(__pyx_CoroutineObject*, PyThreadState*, PyObject*)’:
    ucto_wrapper.cpp:3750:86: error: no match for ‘operator=’ (operand types are ‘std::vector<std::__cxx11::basic_string<char> >’ and ‘std::vector<icu_70::UnicodeString>’)
     3750 |   __pyx_cur_scope->__pyx_v_results = __pyx_cur_scope->__pyx_v_self->tok.getSentences();
@kosloot
Copy link

kosloot commented Dec 17, 2021

Hmm, it was my intention to only add functionality. But probably an oversight here.
I assume getString() and getSentences() are the only affected functions?

I suggest to add 2 member, getUTF8String() and getUTF8Sentences() that perform the old behavior
This implies a small edit in python-ucto.

The other way around, reinstating the old members and adding Unicode variants with other names would be more invasive,
as it would also imply a new releases of frog.

@kosloot
Copy link

kosloot commented Dec 17, 2021

I released the above suggested solution

@proycon
Copy link
Owner Author

proycon commented Dec 17, 2021

Thanks! Works now!

@proycon proycon closed this as completed Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants