Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Added possibility for upload to Duet #1051
@vojtechkral would you please review the pull request once there are no other pressing issues?…
On Tue, Jul 17, 2018 at 12:38 PM, Martin Loidl ***@***.***> wrote: Hi @bubnikv <https://github.com/bubnikv>, May you please have a look at the code? I've tested the new g-code upload now several times with files up to 275Mb and it seems there are no problems at all. Thank you. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1051 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFj5I9U387enuBTz79Squncj3LIxmVNUks5uHb6egaJpZM4VO5ZZ> .
Hi. I've finally gotten around to review this PR. Sorry for the delay.
The PR looks very good in general, I just have a few small-ish requests:
I might post some inline comments too as I proress with the review...
Thank you for the contribution!
@mloidl Thank you. I tested the code on our systems and had to perform a couple of bugfixes/refactoring.
There was a bug with the
I hope you don't mind the changes. The code is in my
Thank you very much for your review. I don't mind about the changes as my c++ is very rusty, so it can just getting better.
Nevertheless i had to do a small change in
I've added it again and pushed the commit to a new
After that single change the connection, file-upload and start print was working again.