Suppress invalid mdadm flag #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All kwargs are passed to raid.assemble, but '--chunks' is invalid in assembly mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All kwargs are passed to raid.assemble, but '--chunks' is invalid in assembly mode.
What does this PR do?
Drops "--chunk" as a keyword argument to raid.assemble
What issues does this PR fix or reference?
saltstack#43517
Previous Behavior
raid.assemble was invoked with
chunksinkwargif specified in the state configuration. This resulted in a failure to assemble an arrayNew Behavior
chunk kwarg is removed if it's present and assembly rather than creation is requested.
Tests written?
No
Manually checked that applying a
raid.presentstate works when whether the underlying device is running, stopped, or gone (via raid.destroy).