Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Refactor to @populated

Most of the tests use an @array with data already in it.
  • Loading branch information...
commit 066725c471e021671098c08a2f089c71909ddfe1 1 parent 4a7d06e
@rking rking authored rking@sharpsaw.org committed
Showing with 11 additions and 19 deletions.
  1. +11 −19 test/test_history_array.rb
View
30 test/test_history_array.rb
@@ -3,6 +3,7 @@
describe Pry::HistoryArray do
before do
@array = Pry::HistoryArray.new 10
+ @populated = @array.dup << 1 << 2 << 3 << 4
end
it 'should have a maximum size specifed at creation time' do
@@ -10,49 +11,40 @@
end
it 'should be able to be added objects to' do
- @array << 1 << 2 << 3
- @array.size.should == 3
- @array.to_a.should == [1, 2, 3]
+ @populated.size.should == 4
+ @populated.to_a.should == [1, 2, 3, 4]
end
it 'should be able to access single elements' do
- @array << 1 << 2 << 3
- @array[2].should == 3
+ @populated[2].should == 3
end
it 'should be able to access negative indices' do
- @array << 1 << 2 << 3
- @array[-1].should == 3
+ @populated[-1].should == 4
end
it 'should be able to access ranges' do
- @array << 1 << 2 << 3 << 4
- @array[1..2].should == [2, 3]
+ @populated[1..2].should == [2, 3]
end
it 'should be able to access ranges starting from a negative index' do
- @array << 1 << 2 << 3 << 4
- @array[-2..3].should == [3, 4]
+ @populated[-2..3].should == [3, 4]
end
it 'should be able to access ranges ending at a negative index' do
- @array << 1 << 2 << 3 << 4
- @array[2..-1].should == [3, 4]
+ @populated[2..-1].should == [3, 4]
end
it 'should be able to access ranges using only negative indices' do
- @array << 1 << 2 << 3 << 4
- @array[-2..-1].should == [3, 4]
+ @populated[-2..-1].should == [3, 4]
end
it 'should be able to use range where end is excluded' do
- @array << 1 << 2 << 3 << 4
- @array[-2...-1].should == [3]
+ @populated[-2...-1].should == [3]
end
it 'should be able to access slices using a size' do
- @array << 1 << 2 << 3 << 4
- @array[-3, 2].should == [2, 3]
+ @populated[-3, 2].should == [2, 3]
end
it 'should remove older entries' do
Please sign in to comment.
Something went wrong with that request. Please try again.