Permalink
Commits on Jan 16, 2013
  1. Version 0.9.11 release

    Final adjustments made to CHANGELOG and CONTRIBUTORS
    banister committed Jan 16, 2013
Commits on Jan 15, 2013
  1. Remove "notes.yml"

    kyrylo committed Jan 15, 2013
  2. turn Pry.config.collision_warnings back off

    This was a horrible mistake, it's stupidly annoying
    
    * in the case of 'rake pry' it warngs every time we do 'cd' (since 'cd' is a top-levle method
      defined by rake)
    
    That's all i can think of right now, but that's still annoying enough.
    banister committed Jan 15, 2013
  3. Add deprecated_commands API

    And rewrite edit-method / show-command to use this API.
    banister committed Jan 15, 2013
  4. gist: Use Pry::CodeCollector (like play/save-file)

    This enables a simplified UI, i.e: gist my_file.rb instead of gist -f my_file.rb
    and `gist my_method` instead of `gist -m my_method`. Unfortunately, we had to kill our
    tests in the process of doing this (gist_spec.rb is just commented out) - however since play
    and save-file have tests and they use the same Pry::CodeCollector object 'gist' is indirectly
    tested. Nonetheless, we should re-add tests at some point
    banister committed Jan 15, 2013
  5. edit: ensure 'edit --ex' always edits the exception

    There was a bug where if 'edit --ex' was invoked in a patched method context
    it would instead to the equivalent of 'edit --method' (patching the current method
    rather than the exception)
    banister committed Jan 15, 2013
  6. Pry::Command::CodeCollector: add #file attribute

    This allows callers to know that CC is working on a file rather than ruby code.
    banister committed Jan 15, 2013
Commits on Jan 14, 2013
  1. Update hist command to the new Slop API

    It was creating a new Slop instance for its own needs, thus and so
    remove the previous abstraction for Slop commands. The
    `ClassCommand::Options` class should be removed because we don't need it
    anymore.
    kyrylo committed Jan 14, 2013
  2. Update relevant tests in "command_spec.rb"

    Make them use the new Slop syntax.
    kyrylo committed Jan 14, 2013
  3. Remove old subcommands cruft

      * use a plain old Slop instance instead of `Options`;
      * remove `ClassCommand::Options` and its tests;
      * add clearer subcommand example (for `Command#subcommand` method);
      * refactor `ClassCommand#slop`;
      * refactor `ClassCommand#complete`.
    
    Slop v3.4.0 has introduced full-featured subcommands. There is no need
    in Pry specific code anymore.
    kyrylo committed Jan 13, 2013
  4. [GEM] Depend on Slop "~> 3.4"

    Slop v3.4.0 includes new syntax for subcommands. And we're going to
    utilise it.
    kyrylo committed Jan 13, 2013
  5. Remove output.write

    Many plugins only define a puts method on the output object. This change
    removse the ability to customize the formatter used when outputting
    variables in `ls`. We should reconsider the best way to do this.
    ConradIrwin committed Jan 14, 2013
  6. Fix errors in "edit_spec.rb" and "editor_spec.rb"

    Basically, the condition was a bit wrong. Let's hope this commit fixes
    it.
    kyrylo committed Jan 14, 2013
  7. Pry.config.collision_warning = true by default

    Let's try this, if it annoys people, we'll just revert it in a patch level
    banister committed Jan 14, 2013
  8. play specs: rewrite -i spec to use redirect_pry_io

    This is because pry_tester doesn't work when the eval_string is mutated by a command
    banister committed Jan 14, 2013
  9. Fix errors on Rubinius and JRuby

    These implementations have slightly different APIs for getting your
    temp directory path.
    kyrylo committed with banister Jan 14, 2013
  10. Remove redundant call to Shellwords.escape

    The "edit" command already intelligently escapes arguments, if need.
    This commit also fixes four failing tests on Windows.
    kyrylo committed with banister Jan 14, 2013
  11. Fix errors in tests on Windows

    Some tests are still failing, though. This commit fixes wrong usage of
    temporary paths on Windows. Please, note: the `edit` command is working
    well; the issue is in poor tests.
    
    Prettify some ugly code in `spec/editor_spec.rb`.
    kyrylo committed with banister Jan 14, 2013
  12. Use proper temp directories for each OS

    Also, there was a failing test on Windows ("should shell-escape files").
    You will see it if you're running tests on Windows. Make it conditional.
    kyrylo committed with banister Jan 14, 2013
  13. Fix indentation (HARDER)

    ConradIrwin committed with banister Jan 13, 2013
  14. Remove needless old_editor restoration

    Unfortunately nested assignments to @old_editor meant that the
    original @old_editor was permanently lost. This caused sporadic
    failures of spec/editor_spec.rb which was relying on Pry.config.editor
    containing a string.
    ConradIrwin committed with banister Jan 13, 2013
  15. Edit: handle blanks in filenames correctly

    Also, move path escaping to `Editor` class. The test is currently
    failing (looks like a bug in `Editor`).
    kyrylo committed with banister Jan 13, 2013
  16. Made sure completions proc do not return nil

    The completion proc returning nil causes errors in input systems that only
    expect strings (e.g. Coolline).
    Mon-Ouie committed Jan 14, 2013
  17. Revert "Add headings for methods in the output of `ls`"

    This reverts commit 1c33a73.
    
    Looks unpleasant for most of Pry users.
    kyrylo committed Jan 14, 2013
Commits on Jan 12, 2013
  1. extract method on redundant code

    AndrewVos committed with rking@sharpsaw.org Jan 12, 2013
  2. clean up redundant code

    AndrewVos committed with rking@sharpsaw.org Jan 12, 2013
  3. refactor raise_errors_if_arguments_are_weird as per @rking advice

    AndrewVos committed with rking@sharpsaw.org Jan 12, 2013