Skip to content
Commits on Jan 16, 2013
  1. @banister

    v0.9.11.1 bugfix

    banister committed
    * forgot to remove 'no_arg' from Pry::Command::CodeCollector, this method no longer exists
    and so 'gist' (when not given any params) would break. Replaced no_arg with empty string ""
    so that 'gist' gists current object/method by default.
  2. @banister

    Version 0.9.11 release

    banister committed
    Final adjustments made to CHANGELOG and CONTRIBUTORS
  3. @banister
  4. @kyrylo
Commits on Jan 15, 2013
  1. @kyrylo

    Remove "notes.yml"

    kyrylo committed
  2. @banister

    turn Pry.config.collision_warnings back off

    banister committed
    This was a horrible mistake, it's stupidly annoying
    
    * in the case of 'rake pry' it warngs every time we do 'cd' (since 'cd' is a top-levle method
      defined by rake)
    
    That's all i can think of right now, but that's still annoying enough.
  3. @banister

    Thread.current -> Pry.current

    banister committed
  4. @banister

    Add deprecated_commands API

    banister committed
    And rewrite edit-method / show-command to use this API.
  5. @banister

    gist: Use Pry::CodeCollector (like play/save-file)

    banister committed
    This enables a simplified UI, i.e: gist my_file.rb instead of gist -f my_file.rb
    and `gist my_method` instead of `gist -m my_method`. Unfortunately, we had to kill our
    tests in the process of doing this (gist_spec.rb is just commented out) - however since play
    and save-file have tests and they use the same Pry::CodeCollector object 'gist' is indirectly
    tested. Nonetheless, we should re-add tests at some point
  6. @banister

    edit: ensure 'edit --ex' always edits the exception

    banister committed
    There was a bug where if 'edit --ex' was invoked in a patched method context
    it would instead to the equivalent of 'edit --method' (patching the current method
    rather than the exception)
  7. @banister

    Pry::Command::CodeCollector: add #file attribute

    banister committed
    This allows callers to know that CC is working on a file rather than ruby code.
Commits on Jan 14, 2013
  1. @banister

    save-file passes on windows :D

    banister committed
  2. @kyrylo

    Update hist command to the new Slop API

    kyrylo committed
    It was creating a new Slop instance for its own needs, thus and so
    remove the previous abstraction for Slop commands. The
    `ClassCommand::Options` class should be removed because we don't need it
    anymore.
  3. @kyrylo
  4. @kyrylo

    Update relevant tests in "command_spec.rb"

    kyrylo committed
    Make them use the new Slop syntax.
  5. @kyrylo

    Remove old subcommands cruft

    kyrylo committed
      * use a plain old Slop instance instead of `Options`;
      * remove `ClassCommand::Options` and its tests;
      * add clearer subcommand example (for `Command#subcommand` method);
      * refactor `ClassCommand#slop`;
      * refactor `ClassCommand#complete`.
    
    Slop v3.4.0 has introduced full-featured subcommands. There is no need
    in Pry specific code anymore.
  6. @kyrylo

    [GEM] Depend on Slop "~> 3.4"

    kyrylo committed
    Slop v3.4.0 includes new syntax for subcommands. And we're going to
    utilise it.
  7. @kyrylo
  8. @ConradIrwin

    Remove output.write

    ConradIrwin committed
    Many plugins only define a puts method on the output object. This change
    removse the ability to customize the formatter used when outputting
    variables in `ls`. We should reconsider the best way to do this.
  9. @kyrylo

    Fix errors in "edit_spec.rb" and "editor_spec.rb"

    kyrylo committed
    Basically, the condition was a bit wrong. Let's hope this commit fixes
    it.
  10. @banister

    Pry.config.collision_warning = true by default

    banister committed
    Let's try this, if it annoys people, we'll just revert it in a patch level
  11. @banister

    play specs: rewrite -i spec to use redirect_pry_io

    banister committed
    This is because pry_tester doesn't work when the eval_string is mutated by a command
  12. @kyrylo @banister

    Fix errors on Rubinius and JRuby

    kyrylo committed with banister
    These implementations have slightly different APIs for getting your
    temp directory path.
  13. @kyrylo @banister

    Remove redundant call to Shellwords.escape

    kyrylo committed with banister
    The "edit" command already intelligently escapes arguments, if need.
    This commit also fixes four failing tests on Windows.
  14. @kyrylo @banister

    Fix errors in tests on Windows

    kyrylo committed with banister
    Some tests are still failing, though. This commit fixes wrong usage of
    temporary paths on Windows. Please, note: the `edit` command is working
    well; the issue is in poor tests.
    
    Prettify some ugly code in `spec/editor_spec.rb`.
  15. @kyrylo @banister

    Use proper temp directories for each OS

    kyrylo committed with banister
    Also, there was a failing test on Windows ("should shell-escape files").
    You will see it if you're running tests on Windows. Make it conditional.
  16. @ConradIrwin @banister

    Fix indentation (HARDER)

    ConradIrwin committed with banister
  17. @ConradIrwin @banister

    Remove needless old_editor restoration

    ConradIrwin committed with banister
    Unfortunately nested assignments to @old_editor meant that the
    original @old_editor was permanently lost. This caused sporadic
    failures of spec/editor_spec.rb which was relying on Pry.config.editor
    containing a string.
  18. @ConradIrwin @banister
  19. @kyrylo @banister

    Edit: handle blanks in filenames correctly

    kyrylo committed with banister
    Also, move path escaping to `Editor` class. The test is currently
    failing (looks like a bug in `Editor`).
  20. @kyrylo
  21. @Mon-Ouie

    Made sure completions proc do not return nil

    Mon-Ouie committed
    The completion proc returning nil causes errors in input systems that only
    expect strings (e.g. Coolline).
  22. @kyrylo

    Revert "Add headings for methods in the output of `ls`"

    kyrylo committed
    This reverts commit 1c33a73.
    
    Looks unpleasant for most of Pry users.
Commits on Jan 12, 2013
  1. @AndrewVos

    extract method on redundant code

    AndrewVos committed with rking@sharpsaw.org
  2. @AndrewVos

    clean up redundant code

    AndrewVos committed with rking@sharpsaw.org
Something went wrong with that request. Please try again.