Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: pry/pry
...
head fork: pry/pry
This comparison is big! We’re only showing the most recent 250 commits
Commits on May 30, 2014
@kyrylo kyrylo Revert "spec/helper.rb: remove the SimpleCov's relics"
This reverts commit 5d4c79f.

Whoops, my bad, SimpleCov *is* actually still present.
3aa74d4
Commits on Jun 04, 2014
@rrrene rrrene Update docs badge in README
Update the URL of the docs badge to include it from inch-ci.org instead of inch-pages.github.io (the former being the successor of the Inch Pages project).
1e3d7aa
Commits on Jun 09, 2014
@ConradIrwin ConradIrwin v0.10.0 929c608
@ConradIrwin ConradIrwin Fix changelog version number 69d4c00
Commits on Jun 10, 2014
@baweaver baweaver s/surroungind/surrounding line 19 86017aa
@ConradIrwin ConradIrwin Merge pull request #1243 from baweaver/patch-1
s/surroungind/surrounding line 19
c9dc06f
Commits on Jun 12, 2014
@jalvarezsamayoa jalvarezsamayoa Remove deprecation warning for File.exists?
Rspec 3.0 + Ruby 2.1.1 raises deprecation warning 'warning: File.exists? is a deprecated name, use File.exist? instead'
8aa9b2f
Commits on Jun 24, 2014
@stevenharman stevenharman Clean up ambiguous method warnings
When running with Ruby warnings, these usages of `#match` are ambiguous,
but can be made explicit with parens.
e48ed7c
@ConradIrwin ConradIrwin Merge pull request #1255 from stevenharman/clean-up-ambiguous-method-…
…warnings

Clean up ambiguous method warnings
a6fad5f
@stevenharman stevenharman Cleanup unused local var warning
We're not using the `ext` local variable, so just ignore it by taking
the first element from the split - the filename.
7c47e0e
@stevenharman stevenharman Cleanup method redefined warning for grep
Since we define a "reader" method, this is really an `attr_writer`.
0fff769
@stevenharman stevenharman Cleanup * interpreted as argument prefix warning
The splat was a bit ambiguous in these cases, resulting in a Ruby
warning. Adding parens makes it explicit and silences the warning.
401c910
@stevenharman stevenharman Clean File.exists? deprecation warning
This API has been deprecated in Ruby 2.1, so use the File.exist? API.
0fd61f6
@stevenharman stevenharman Cleanup private attribute? warning
private attr_* methods raise a Ruby warning. Instead, just define a
simple reader method.
a263ed5
@stevenharman stevenharman Cleanup method redefined warnings
These methods are defined via some metaprogramming earlier in the class.
Since they are also defined by the same mechanism in the pry_class file,
I've chosen to undef them prior to defining a new version. An
alternative would be to remove these from the
Pry::Config::Convenience::SHORTCUTS array and define them manually where
necessary.
77d5b8e
Commits on Jun 29, 2014
@fancyremarker fancyremarker Revert 16c6037 to fix spec/Procfile
Fixes #1258
be3823a
Commits on Jul 06, 2014
@rf- rf- Always expand history file path (fix #1262) 98cbcc3
@rf- rf- Fix delegation of `quiet?` config method (fix #1261)
Because we were defining `quiet?` on Pry::Config::Default, calls to it
would always delegate to the default config object and then return
false. To make it possible to enable quiet mode, we need the
transformation from `quiet?` to `quiet` to happen earlier. The simplest
way to accomplish this is just to define the `quiet?` method explicitly.
7bf2549
Commits on Jul 07, 2014
@rf- rf- Merge pull request #1246 from jalvarezsamayoa/patch-1
Remove deprecation warning for File.exists?
5101cd4
@adelevie adelevie call #count on Array instead of Enumerator in pry_instance.rb 801a995
Commits on Jul 19, 2014
@AndrewVos AndrewVos Fix test that fails in docker
This test fails because it's not using File.join on ENV["HOME"] (which
is null when run under root in docker) which means that we're asserting
on the direction "//test_history" instead of "/test_history".
341c19f
@AndrewVos AndrewVos Add scripts to `rake test` on all rubies
Run ./multi_test.sh to test all rubies that are configured in
Dockerfile.
81455ef
Commits on Jul 20, 2014
@silentdth silentdth support for redcar editor 1277815
@ConradIrwin ConradIrwin Merge pull request #1270 from silentdth/master
support for redcar editor
89b3890
@AndrewVos AndrewVos Add rake task for running tests on multiple rubies 8f8dfc8
@ConradIrwin ConradIrwin Merge pull request #1268 from AndrewVos/multi-test
Easily `rake test` in a whole load of rubies
ec008f6
@ConradIrwin ConradIrwin Merge pull request #1256 from stevenharman/clean-up-ruby-warnings
Cleanup remaining Ruby warnings
3bc4219
@ConradIrwin ConradIrwin Merge pull request #1242 from rrrene/patch-2
Update docs badge in README
0ff6fa6
@JoshCheek JoshCheek Fix Pry.config.hooks # => parent's hooks
PROBLEM DESCRIPTION
===================

The child caches a dup of the parent's hooks,
so it does the correct thing after being accessed the first time.

But the first time it is called, it doesn't return its cached duped value,
it returns the parent's value. This causes 2 bugs:

1. The first hook declared will get "lost", because it is declared
   to the parent hooks, not the child's hooks. And after that first
   accessing, only the child's hooks will be used
2. The parent's hooks (which are probably the ones from
   [the default](https://github.com/pry/pry/blob/0ff6fa61d4197feace48b422b5e3d3fb5948cbdd/lib/pry/config/default.rb#L35-37))
   are going to get hooks declared on them that shouldn't be
   (well, presumably shouldn't be, given the explicit check for
   this case and duping to avoid it).
   So if another config object was initialized with the same parent,
   it would wind up with hooks that it didn't want/expect.

I assume all the other keys work fine because they are value objects,
so if anything wanted to change the value, it would reassign the key
to the config object rather than mutating the returned value.

Mutability *sigh* yallknowwhatimsayin

SOLUTION DESCRIPTION
====================

Return the cached duped child value instead of the parent value.

EXAMPLE
=======

This code from
[the docs](https://github.com/pry/pry/blob/0ff6fa61d4197feace48b422b5e3d3fb5948cbdd/lib/pry/hooks.rb#L8-11)
will not print "hello", because it's being declared to the parent hook.

```ruby
Pry.config.hooks.add_hook(:before_session, :say_hi) { puts "hello" }
```

This code will, b/c it's being declared to the cached, duped child hook.

```ruby
Pry.config.hooks
Pry.config.hooks.add_hook(:before_session, :say_hi) { puts "hello" }
```

ISSUE IMPACT
============

Fixes #1254

Might fix or have something to do with these issues:

* #1244 Totally thought I got it, but then couldn't reproduce again later
  and just don't understand how JRuby builds, so might just be a problem
  with how I was trying to reproduce it.
* #1171 Maybe, depending on if Eclipse integrates with it using the
  hooks, alternatively, could be the same issue as the one above,
  they might both still be broken. Or both fixed and I can't figure out
  how to prove it. Dunno.

OTHER THOUGHTS
==============

I'm writing Github flavoured markdown,
but I'm not actually sure if it will get rendered as such in the PR.
Esp since git considers leading octothorpes as comments and not headers,
and removes them...

Guess we'll see... bottoms up, friends!
d8490e8
@kyrylo kyrylo Merge pull request #1271 from JoshCheek/fix_config_hooks_value_caching
Fix Pry.config.hooks # => parent's hooks
61ebccf
Commits on Jul 21, 2014
@kyrylo kyrylo Revert "Fix tests"
This reverts commit 93e81d7.
80f1b41
@kyrylo kyrylo Revert "Get rid of Code#highlighted"
This reverts commit 5599b0a.

And fixes jruby-head.

https://travis-ci.org/pry/pry/jobs/30420112
c6f8d5c
Commits on Jul 23, 2014
@sgerrand sgerrand Explicitly declare the required Ruby version 3c647d7
Commits on Aug 10, 2014
@JoshCheek JoshCheek Methods previously patched will be patched in future edits cbc9dec
@JoshCheek JoshCheek Methods defined in console can be repeatedly edited
Fixes #1269
c1c4a51
@JoshCheek JoshCheek Fix broken link 7283139
@JoshCheek JoshCheek Fix for Rubinius
Problem
-------

Currently, CI is failing b/c singleton_class? was added to MRI2.1 but not Rbx.
e.g. https://travis-ci.org/pry/pry/builds/32133642

However, I did not look into why it is suddenly failing now.
For quite a while, Rbx builds were erroring out (e.g.  https://travis-ci.org/pry/pry/jobs/30421343)
They are no longer failing, but are now erroring, for the above reason.

Context
-------

Rbx has recently (11 days ago, 30 July 2014) received this method
rubinius/rubinius@2e71722

But the functionality has been available since April 2011
rubinius/rubinius@4310f6b

Solution
--------

Fix the failures by falling back to the older functionality if we are on Rubinius,
and the new method is unavailable.
d141301
@JoshCheek JoshCheek Switch test suite to RSpec
Removes Bacon and Mocha

Mostly this went smoothly. There were a few errors that I fixed along
the way, e.g. tests that were failing but for various reasons still
passed. Should have documented them, but didn't think about it until
very near the end. But generaly, I remember 2 reasons this would happen:
`lambda { raise "omg" }.should.raise(RuntimeError, /not-omg/)` will pass
because the second argument is ignored by Bacon. And `1.should == 2`
will return false instead of raising an error when it is not in an it
block (e.g. if stuck in a describe block, that would just return false)

The only one that I felt unsure about was spec/helpers/table_spec.rb
`Pry::Helpers.tablify_or_one_line('head', %w(ing)).should == 'head: ing'`
This is wrong, but was not failing because it was in a describe block
instead of an it block.  In reality, it returns `"head: ing\n"`,
I updated the test to reflect this, though I don't know for sure
this is the right thing to do
1df8c26
@JoshCheek JoshCheek Switch test suite to RSpec
Removes Bacon and Mocha

Reasoning explained in this comment: #277 (comment)

Mostly this went smoothly. There were a few errors that I fixed along
the way, e.g. tests that were failing but for various reasons still
passed. Should have documented them, but didn't think about it until
very near the end. But generaly, I remember 2 reasons this would happen:
`lambda { raise "omg" }.should.raise(RuntimeError, /not-omg/)` will pass
because the second argument is ignored by Bacon. And `1.should == 2`
will return false instead of raising an error when it is not in an it
block (e.g. if stuck in a describe block, that would just return false)

The only one that I felt unsure about was spec/helpers/table_spec.rb
`Pry::Helpers.tablify_or_one_line('head', %w(ing)).should == 'head: ing'`
This is wrong, but was not failing because it was in a describe block
instead of an it block.  In reality, it returns `"head: ing\n"`,
I updated the test to reflect this, though I don't know for sure
this is the right thing to do

This will fail on master until #1281 is merged.
This makes #1278 unnecessary.
144d32e
Commits on Aug 11, 2014
@JoshCheek JoshCheek Run test in an object of its own
Otherwise we are sharing state with the toplevel binding,
which allows other tests to modify its values causing this to fail
e.g. https://travis-ci.org/pry/pry/jobs/32184681
990d3e8
@ConradIrwin ConradIrwin Merge pull request #1280 from JoshCheek/patch-1
Fix broken link
b7278db
Commits on Aug 15, 2014
@JoshCheek JoshCheek Fix specs for JRuby 83b0191
@JoshCheek JoshCheek Merge branch 'fix-for-rubinius' into switch-to-rspec
I was asked to fix it for Rbx and JRuby
(#1282 (comment))
so decided to go ahead and merge this.

Conflicts:
	spec/commands/ls_spec.rb
	spec/commands/shell_command_spec.rb
c7e7458
Commits on Aug 16, 2014
@ConradIrwin ConradIrwin Merge pull request #1282 from JoshCheek/switch-to-rspec
Switch test suite to RSpec
4c10261
@ConradIrwin ConradIrwin Merge pull request #1253 from adelevie/master
Ensure that pry_instance doesn't pass nil to +=
c53c6b6
@ConradIrwin ConradIrwin Don't return cols = 0 [Fixes #1267]
It just causes zero division errors.
b252d3a
@ConradIrwin ConradIrwin v0.10.1 191dc51
@ConradIrwin ConradIrwin Merge pull request #1279 from JoshCheek/issue-1269-patching-methods
Issue 1269 patching methods
bf3d7cf
@ConradIrwin ConradIrwin Merge pull request #1273 from sgerrand/requires-ruby-1.9
Explicitly declare the required Ruby version
11024ed
@ConradIrwin ConradIrwin Use new syntax for tests 0e091ff
@ConradIrwin ConradIrwin Merge commit '0e091ff6c35691711929c16a8e407ebf5fbc88b2' b26a5ec
@ConradIrwin ConradIrwin Merge pull request #1259 from fancyremarker/fix-spec-procfile
Restore spec/Procfile functionality
7e73e72
Commits on Aug 18, 2014
@rf- rf- Enable `should` syntax for RSpec
We can always get rid of this if we switch all of the specs to use
`expect` instead, but until then we should probably make our RSpec
configuration match how our specs are written.
6d5eb08
Commits on Aug 25, 2014
@drwl drwl Fix for NoMethodError when using install-command with no gem configur…
…ation
e41f828
Commits on Sep 01, 2014
@JoshCheek JoshCheek Refactor jump_to and spec
Update jump_to command's spec to RSpec 3 (#1294)
Perform some refactorings along the way.
bf24df0
Commits on Sep 10, 2014
@dsisnero dsisnero fixed Pry::Editor#invoke_editor
Pry::Editor doesn't have a class method called invoke_editor. Fixed to call on an initialized Pry::Editor instance
a7bba4f
Commits on Sep 12, 2014
@krissi krissi Remove slash-change of windows paths 367d02c
Commits on Sep 13, 2014
@stefan-lz stefan-lz Enable syntax highlighting for Rakefile and other similarly named files 8cdcd9e
Commits on Oct 02, 2014
Ahsan Dar gem install fails when config doesn't have --user-install set 47fac20
Commits on Oct 14, 2014
@tricknotes tricknotes Handle error about frozen object in Ruby 2.2
This kind of error message seems to be updated in Ruby 2.2.

For example, the following code throws an error that has different
error message with Ruby version:
```
"".freeze.instance_eval do
  def hi
  end
end
```

In Ruby 2.1.3:
> RuntimeError: can't modify frozen Class

In Ruby 2.2.0-preview1:
> RuntimeError: can't modify frozen object
74784e8
@tricknotes tricknotes Test against Ruby 2.2 on Travis CI 3398733
@sferik sferik Replace map.flatten(1) with flat_map b07fe4b
@kyrylo kyrylo Merge pull request #1308 from sferik/flat_map
Replace map.flatten(1) with flat_map
e5a376f
@kyrylo kyrylo Merge pull request #1307 from tricknotes/ruby-22
Fix for Ruby 2.2.0
0975f5d
@kyrylo kyrylo Merge pull request #1306 from ahsandar/master
gem install fails when config doesn't have --user-install set
70f9391
Commits on Oct 26, 2014
@carlzulauf carlzulauf Only load plugins that support current pry 69b025e
Commits on Oct 31, 2014
@kyrylo kyrylo Merge pull request #1298 from dsisnero/patch-1
fixed Pry::Editor#invoke_editor
3427566
Commits on Nov 21, 2014
@strcmp strcmp add 'gem-readme' command. 5cc1e36
@rf- rf- Merge pull request #1321 from rpag/gem-readme
add 'gem-readme' command.
4279dac
@strcmp strcmp group gem-readme with other gem-* commands 87df0e4
Commits on Nov 23, 2014
@strcmp strcmp add 'gem-search' command c675169
@rf- rf- Merge pull request #1322 from rpag/gem-search
add 'gem-search' command
cafd3d6
Commits on Nov 25, 2014
@rf- rf- Add rbx-2 to allowed failures for now dc22b73
Commits on Nov 30, 2014
@yuki24 yuki24 Cleanup warnings
 * `lib/pry/code.rb:271: warning: instance variable @with_marker not initialized`
 * `lib/pry/commands/show_info.rb:93: warning: instance variable @used_super not initialized`
 * `lib/pry/commands/whereami.rb:140: warning: instance variable @method_code not initialized`
 * `lib/pry/history.rb:86: warning: File.exists? is a deprecated name, use File.exist? instead`
 * `lib/pry/module_candidate.rb:61: warning: instance variable @source not initialized`
 * `lib/pry/module_candidate.rb:79: warning: instance variable @source_location not initialized`
 * `lib/pry/pager.rb:137: warning: instance variable @system_pager not initialized`
 * `lib/pry/pager.rb:186: warning: instance variable @pager not initialized`
 * `lib/pry/wrapped_module.rb:311: warning: instance variable @all_source_locations_by_popularity not initialized`
66dc90b
robert Merge pull request #1327 from yuki24/without-warnings
Cleanup warnings
4fe3d3b
Commits on Dec 04, 2014
@keeganlow keeganlow Prevent additional single-line if indentations [Fixes #1325] 2404d68
@ConradIrwin ConradIrwin Merge pull request #1329 from lowensk/issue-1325-single-line-if
Prevent additional single-line if indentations [Fixes #1325]
9afc501
Commits on Dec 10, 2014
@ktdreyer ktdreyer spec: rm stray reference to OpenStruct
OpenStruct was removed in 91d412c, but
a stray reference remained in the test suite. Remove it here.
70942ad
Robert Merge pull request #1332 from ktdreyer/rm-openstruct
spec: rm stray reference to OpenStruct
ea16f41
Commits on Dec 13, 2014
@strcmp strcmp Behavior#[] traverses through chain of defaults.
_pry_.config['output'] returns $stdout, by traversing back to
Pry::Config::Default#output.
1486996
@strcmp strcmp fixes #1277 27e9199
@strcmp strcmp update CHANGELOG.md 1fd16b5
@strcmp strcmp consistent names for private Behavior methods 233aa81
Commits on Jan 08, 2015
@eboswort eboswort modify regex so not_a_real_file? does not automatically return false …
…when file has parens in path
fdb7069
Commits on Jan 10, 2015
@tbpgr tbpgr Fix history clear bag(No re-init @original_lines) b99b4d4
Commits on Jan 13, 2015
@rrrene rrrene Update docs badge in README
[ci skip]
6aed888
@dominic-ew dominic-ew using __send__ to prevent calling TCPSocket#send 6ff4400
@ConradIrwin ConradIrwin Merge pull request #1346 from dominic-ew/patch-1
using __send__ to prevent calling TCPSocket#send
43091c5
@ConradIrwin ConradIrwin Merge pull request #1345 from rrrene/patch-3
Update docs badge in README
db9f4e9
Commits on Jan 15, 2015
@rf- rf- Merge remote-tracking branch 'drwl/fixes-issue-1286' (fix #1286)
Conflicts:
	lib/pry/rubygem.rb
cd06c88
@rf- rf- Merge pull request #1295 from JoshCheek/spec_for_jump_to_command
Refactor jump_to and its spec
892cdb0
@rf- rf- Reduce line length in jump-to 7153d82
@rf- rf- Merge pull request #1302 from stefan-lz/rakefile_syntax_highlighting
Enable syntax highlighting for Rakefile and other similarly named files
dab174b
@rf- rf- Add spec for 8cdcd9e 3bcb2e0
@rf- rf- Merge pull request #1300 from krissi/master
Fix edit command on windows
5ab72ee
@rf- rf- Merge pull request #1339 from CasperSleep/master
Fix "not_a_real_file?" regex
118d658
@krissi krissi Replace should with specify 9349a58
@krissi krissi Remove example-alias d5748ce
@krissi krissi Add rubymine directory to ignore list 5b12626
@krissi krissi Update specs using yield matcher 72b486f
@krissi krissi Update specs using inner_scope helper aec888e
Christian Haase Add missing Pry::Code#respond_to_missing? e99e624
@rf- rf- Don't render Pry::Code for `#respond_to_missing?`
Since `#to_s` always returns a String, we don't need to incur the cost
of rendering just to check whether we can respond to a method.
0b198ca
@strcmp strcmp support custom implementation of BasicObject#inspect.
If BasicObject or a subclass of BasicObject implements #inspect,
we will try to use its return value as output but if that fails,
we'll fallback on __id__.

fixes #1341
81fc96f
@strcmp strcmp update CHANGELOG.md 5ed0e93
@strcmp strcmp define instance methods on Pry::Helpers::Text 1d8a633
@strcmp strcmp add Pry::ColorPrinter specs 7cab9c4
@strcmp strcmp add spec, & cleanup after existing spec 4870fcb
@strcmp strcmp add tests that cover Object subclasses 741782b
Commits on Jan 23, 2015
@mvz mvz Enable warnings during spec runs cc6bbb5
@mvz mvz Fix 'shadowing outer local variable' warning dadddae
@mvz mvz Fix 'possibly useless use of == in void context' warnings 04dc46f
@mvz mvz Fix some warnings 96b61f1
@mvz mvz Fix binary operator % warning 2f0b5a4
@mvz mvz Fix more warnings 3376e6a
@mvz mvz Fix warning generated by editor action d4e4d4d
@mvz mvz Undefine method possibly defined in session dd16a5d
@mvz mvz Avoid ignored literals 3eb7c55
@mvz mvz Catch at least some errors in #safe_to_evaluate? 992d21e
@mvz mvz Fix more unused local variable warnings efd0ed8
@mvz mvz Fix possible reference to past scope warnings
This type of warning was introduced in Ruby 2.2
5e8d69e
@mvz mvz Fix JRuby-specific warnings ffff9ba
Commits on Feb 01, 2015
r20 Merge pull request #1355 from mvz/fix-warnings
Fix Warnings
738c60d
Commits on Feb 16, 2015
@banister banister Use _pry_.pager if possible
The prior code was always using Pry.new.pager -- this was weird for a few reasons:
1) _pry_ is always available (afaict) so why not just call _pry_.pager rather than creating a throway pry object for this?
2) When creating a new Pry instance (via Pry.new) the when_started hook is run...this resulted in some errors and strange behaviour since a naked instance created with Pry.new is not properly configured (it misses a 'target' (binding)

I left the old code in there though to trigger when _pry_ is not available since I assume it's there for good reason?!
1e71d84
@banister banister Rename helper spec: singleton_class(arg) -> eigenclass(arg)
It was causing the most ridiculous non-sensical test failures, possibly a bug in Ruby itself, but this patch fixes it
0807328
@banister banister Merge pull request #1365 from pry/bugfix/fix-spec-failures
Bugfix/fix spec failures
05abf09
Commits on Feb 26, 2015
@kyrylo kyrylo file_formatter: call #around on Pry::Code instead of String
Fixes #1349 (Bug in `cat` since 0.10.1)
6dc8007
@kyrylo kyrylo file_formatter_spec: simplify tests a bit
* simplify test names

* use described_class instead of the actual name.
  It's shorter.
2542f07
@kyrylo kyrylo terminal: rescue Errno::EOPNOTSUPP
Fixes #1352 (crash when $stdout is a socket)

Spin defines its own `#tty?` method on `$stdout`, which breaks Pry.

https://github.com/jstorimer/spin/blob/9112a702a1b8b399301011244b5c3089d6f1c9b3/lib/spin.rb#L342
2a05351
Commits on Feb 27, 2015
@kyrylo kyrylo base_helpers: remove the #mri_20? and #mri_19? methods
They're not used anywhere.
0176ed6
@kyrylo kyrylo wrapped_module:candidate: reflect the directory structure accordingly
According to our code base, we use the convention, which says that if a
class is nested, it should also be reflected in the directory structure.
6a690e1
@kyrylo kyrylo show-source: if the current context is a C object, display a warning
Fixes #691 (some adjustments to show-source behaviour)
f289862
@kyrylo kyrylo CHANGELOG: mention the fix of #691
The commit that fixes it:

f289862
02f7493
Commits on Feb 28, 2015
@kyrylo kyrylo method: amend backticks to avoid confusion
The confusion is that some users think that it's a shell command, rather
than a Pry command (see: #1350)
84b30eb
@banister banister Merge pull request #1364 from pry/refactor/dont-throwaway-pry-instance
Use _pry_.pager if possible
6050a06
@kyrylo kyrylo Merge pull request #1313 from carlzulauf/only-supported-plugins
Skip plugins which explicitly don't support current pry
33428ff
@kyrylo kyrylo Merge branch 'fix_hist_clear_negative_array_size' of https://github.c…
…om/tbpgr/pry into tbpgr-fix_hist_clear_negative_array_size
305e5a9
@kyrylo kyrylo Merge branch 'tbpgr-fix_hist_clear_negative_array_size' 63db20e
@kyrylo kyrylo CHANGELOG: mention recent changes f0cbec5
Commits on Mar 01, 2015
@kyrylo kyrylo config/default: don't buffer output
Unbuffered output allows using the tee command.
00072e8
Commits on Mar 02, 2015
@kyrylo kyrylo repl: don't reopen 'dev/tty' on each carriage return when piping b68763a
@kyrylo kyrylo repl: factorout the "coolline" duplication to its own method e92ac92
@kyrylo kyrylo repl: try setting the readline output on carriage return
If the first "input" is a StringIO, so the old approach never sets the
realine output, so we have to check every time.
159254c
@boxofrox boxofrox Fix missing require for tab completion within strings
Fixes pry/pry#1330

Signed-off-by: Justin Charette <charetjc@gmail.com>
3156f10
Commits on Mar 03, 2015
@kyrylo kyrylo repl: set readline output to Pry's output
Fixes #1334 (#1334)

However, it breaks support for Foreman [1]. I patched Foreman, so we
could still enjoy Pry.

[1]: #1290
6e2da33
@kyrylo kyrylo Merge pull request #1370 from boxofrox/fix/missing-stringscanner-on-t…
…ab-completion

Fix missing require for tab completion within strings
ee2513b
Commits on Mar 04, 2015
@kyrylo kyrylo CHANGELOG: mention the fix of StringScanner exception df3fc3e
Commits on Mar 05, 2015
@kyrylo kyrylo helpers/text: respect RL_PROMPT_START_IGNORE and RL_PROMPT_END_IGNORE
Addresses to #493. Fixes the described bug in the situation when you use
helper methods in your Pry prompt like this:

  Pry.prompt = [
    proc { |_, _, _| Pry::Helpers::Text.red("YO > ") },
    proc { |_, _, _| "| "}
  ]
a293f1f
@kyrylo kyrylo Merge pull request #1388 from pry/493-color-prompt
helpers/text: respect RL_PROMPT_START_IGNORE and RL_PROMPT_END_IGNORE
9515c18
Commits on Mar 06, 2015
@kyrylo kyrylo CHANGELOG: mention the fix of a293f1f 05a3ba7
@kyrylo kyrylo helpers/text: when strip colours, also strip special characters
Fixes build failures introduced in

  a293f1f
c220c40
@kyrylo kyrylo Revert "Safe to append with #<< here after all."
Fixes #1387 ('pry -e' messes with the terminal)

This reverts commit 6ffc748.

Cc: @havenwood :D
65fdcba
Commits on Mar 08, 2015
@kyrylo kyrylo Fix regression with respect to space prefixes
Fixes #1369 (Prefixing commands with a space is not working)

The regression was introduced by this commit:

  68bcca2

Since then the main logic for the REPL was hugely refactored. This
refactoring morphed the error into this commit:

  e020f8c

Sorry about this hacky solution.
dd92e2a
@kyrylo kyrylo Merge pull request #1390 from pry/1369-blank-prefix-fix
Fix regression with respect to space prefixes
411a8db
Commits on Mar 10, 2015
@kyrylo kyrylo specs: convert to shoulds to expects 96c6958
Commits on Mar 11, 2015
@kyrylo kyrylo Refactor command hooks so they could use Pry::Hooks (newer API)
Fixes #651 ({after,before}_command hooks should be unified with
Pry::Hooks system)

* The support for the `Pry.commands.{after,before}_command` API was kept
* Hooks defined via the older API use random names
* The order of hooks execution was changed from LIFO to FIFO
47d8103
@kyrylo kyrylo hooks: make sure hooks are strings no matter what 9d21ebe
@kyrylo kyrylo CHANGELOG: mention changes to the hooks API with respect to commands 5db1411
@kyrylo kyrylo Merge pull request #1391 from pry/651-command-hooks-refactoring
Refactor command hooks so they could use Pry::Hooks (newer API)
d67b5fd
@kyrylo kyrylo CHANGELOG: fix formatting 6a5ea78
@richo richo cli: parse_opts should not actually spin off a repl f3339c8
Commits on Mar 14, 2015
@kyrylo kyrylo hooks: remove superfluous #merge_arrays fa40027
@kyrylo kyrylo hooks: merge #uniq_keeping_last with #merge! and simplify it 0bca85d
@kyrylo kyrylo hooks: reformat the definition of the #hooks method
This is the style we use in this project.
a3a9831
@kyrylo kyrylo hooks: rename #clear to #clear_event hooks and get rid of the alias 590d736
@kyrylo kyrylo hooks: remove obvious examples from the comments d768662
@kyrylo kyrylo hooks: remove unused method #clear_all 958f63e
@kyrylo kyrylo hooks: simplify comments and wrap everything to 80 chars 026081f
@kyrylo kyrylo hooks: use the default value for hash instead of checking 9e66680
@kyrylo kyrylo hooks: don't overwrite the `event_name` parameter in some methods 2c8b745
@kyrylo kyrylo hooks: simplify #hooks_exists? dc1428c
@kyrylo kyrylo hooks: remove old API's using hooks altogether db8ba4a
@kyrylo kyrylo Merge pull request #1395 from pry/1392-pry-hooks-refactoring
1392 pry hooks refactoring
71049ce
Commits on Mar 17, 2015
@kyrylo kyrylo Merge pull request #1372 from kyrylo/1334-tee-support
Make Pry work with tee
b93ed49
@kyrylo kyrylo Remove support of Foreman altogether
In order to support it we needed to patch Foreman. However, the Foreman
author rejected it.

Details: ddollar/foreman#536
491e677
@kyrylo kyrylo CHANGELOG: mention recent changes 5eb4e23
@jbarreneche jbarreneche Avoid loop in weird method locator c2ed9ec
Commits on Mar 26, 2015
@richo richo Don't include an extraneous newline in exec_string handling
This still deals correctly with the case where there is more than one -e
option passed
99db3e4
@richo richo Handle cli arguments after loading config files etc 3c8cfe5
@kyrylo kyrylo Merge pull request #1393 from richo/richo-parse-opts
cli: parse_opts should not actually spin off a repl
d70f065
Commits on Mar 31, 2015
@buddhamagnet buddhamagnet alias whereami to pwd cb0af59
@kyrylo kyrylo Merge pull request #1404 from buddhamagnet/add-pwd
Alias whereami to pwd
b41ae64
@banister banister Revert "Alias whereami to pwd" bc6ad1c
@banister banister Merge pull request #1406 from pry/revert-1404-add-pwd
Revert "Alias whereami to pwd"
2c32d5e
Commits on Apr 02, 2015
@tdg5 tdg5 Return nil from PryClass::run_command c6ceb40
Commits on Apr 05, 2015
@mtsmfm mtsmfm Fix warning
```
warning: instance variable @readline_output not initialized
```
6e5d24d
@kyrylo kyrylo Merge pull request #1409 from mtsmfm/fix-warn
Fix warning
e273b1b
Commits on Apr 09, 2015
@drbrain drbrain Use CPU-less platforms for windows
There is no need to include the CPU in the platform string as there is
no compiled code shipped in the pry gems.  The only difference is the
dependency.

Pry became a victim of rubygems/rubygems#1058 which will be fixed in
rubygems/rubygems#1120.  I would also like to raise awareness of proper
use of platform parts while I'm fixing the bug in RubyGems.
ee0ea8f
Commits on Apr 10, 2015
@kyrylo kyrylo Merge pull request #1410 from drbrain/fix-package-platforms
Use CPU-less platforms for windows
c3e671e
@kyrylo kyrylo Merge pull request #1408 from tdg5/run_command_returns_nil
Return nil from PryClass::run_command
c47d566
Commits on Apr 19, 2015
@takiy33 takiy33 Remove explicit 'rubygems' require cdfd3b0
Commits on May 11, 2015
@trayo trayo Changes deprecated ‘File.exists’ to ‘File.exist’ 86154b4
@kyrylo kyrylo Merge pull request #1420 from trayo/master
Changes deprecated ‘File.exists’ to ‘File.exist’
cf76089
Commits on May 21, 2015
@getaaron getaaron Minor capitalization changes in README fc73767
@kyrylo kyrylo Merge pull request #1422 from getaaron/capitalization
Minor capitalization changes in README
b0ed8b9
Commits on May 31, 2015
@kyrylo kyrylo Merge pull request #1414 from takiy33/remove-rubygems-require
Remove explicit 'rubygems' require
7d58ace
Commits on Jun 02, 2015
@takiy33 takiy33 Use --no-document option instead of --no-rdoc and --no-ri option 599bb03
@kyrylo kyrylo Merge pull request #1426 from takiy33/fix_docker
Use --no-document option instead of --no-rdoc and --no-ri option
0cd2122
Commits on Jun 14, 2015
@takiy33 takiy33 Make comment to YARD format 0d3ecbc
@kyrylo kyrylo Merge pull request #1430 from takiy33/fix_yard
Make comment to YARD format
c189da1
Commits on Jun 16, 2015
@kyrylo kyrylo method: clarify the fail message
Fixes #1431 (Error message typo. ("gem-install"))
ad892d7
Commits on Jun 17, 2015
@clemenslee clemenslee Shell command .cd takes the environment's CDPATH variable into account. d2215dc
@clemenslee clemenslee Test added for .cd taking the CDPATH into account. 2c2e393
@kyrylo kyrylo Merge pull request #1433 from kyrylo/clemenslee-clemenscdpath
Add support for CDPATH for `.cd`
03c7887
@kyrylo kyrylo Refactor CDPATH and its tests
The original code was confusing and had incompatible style.
f6966b3
@kyrylo kyrylo shell_command: simplify the return conditions 2b7785a
@kyrylo kyrylo shell_command_spec: fix and simplify tests c0053cd
@kyrylo kyrylo Add .gitkeep to spec/fixtures/cdpathdir/ in order to fix tests d8a2933
@kyrylo kyrylo Merge pull request #1434 from kyrylo/cdpath-refinements
Refactor CDPATH and its tests
bd9f879
@kyrylo kyrylo CHANGELOG: mention recent important changes for the upcoming release 3b483a9
Commits on Jun 18, 2015
@richo richo Split out session standup 9386e06
Commits on Jun 21, 2015
@takiy33 takiy33 Fix warning: Using the raise_error matcher without providing a specif…
…ic error
e2d3d13
Commits on Jun 22, 2015
@strcmp strcmp Merge pull request #1437 from takiy33/fix_rspec_warnings
Fix warning: Using the raise_error matcher without providing a specific error
1f95114
@strcmp strcmp update copyright year to 2015.
[ci skip]
bf2fbcc
@wteuber wteuber fix namespace typo a847786
@kyrylo kyrylo Merge pull request #1439 from wteuber/master
fix namespace typo
a500b3d
Commits on Jun 24, 2015
@egwspiti egwspiti Syntax highlight <tt> tags in documentation output. 0e5610e
@egwspiti egwspiti Update CHANGELOG. 7792e24
@kyrylo kyrylo Merge pull request #1440 from egwspiti/master
Syntax highlight <tt> tags in documentation output.
42ff1b6
Commits on Jun 27, 2015
@tdg5 tdg5 Hooks#add_event documentation fix a2f2e5a
@kyrylo kyrylo Merge pull request #1441 from tdg5/doc_fix
Hooks#add_event documentation fix
4b52c03
Commits on Jun 28, 2015
@richo richo Finish setting up the session if we begin 4f41da2
@richo richo Make session finalisation idempotent 3e2477f
@egwspiti egwspiti Don't raise when directory permissions don't allow file expansion. c42f9af
@egwspiti egwspiti Delete debug puts. b467024
@egwspiti egwspiti Make spec work for ruby 1.9.3 and possibly other versions. 40a83eb
@richo richo Finish setting up the session in Pry.start 48473fb
@richo richo Reset finalization state c4d2528
Commits on Jun 29, 2015
@kyrylo kyrylo Merge pull request #1435 from richo/richo-ooo
Split out session standup
001a00d
@egwspiti egwspiti Use &lt; and &gt; instead of < and > 3adf6d8
@egwspiti egwspiti Update CHANGELOG. 0d09095
@kyrylo kyrylo Merge pull request #1398 from jbarreneche/bug/module-prepend-whereami
Bug with module#prepend in ruby 2.0.0
271212d
@kyrylo kyrylo Merge pull request #1443 from egwspiti/master
Don't raise when directory permissions don't allow file expansion.
f117fde
Commits on Jun 30, 2015
@egwspiti egwspiti Allow pry commands to work even when #call is defined on Symbol.
When #call is defined on Symbol, Slop (3.6.0) fails.
31ec9f1
@kyrylo kyrylo Merge pull request #1445 from egwspiti/allow_call_defined_on_Symbol
Allow pry commands to work even when #call is defined on Symbol.
745ac2d
Commits on Jul 08, 2015
@takiy33 takiy33 Remove duplicate after hook 9ffd45b
@kyrylo kyrylo Merge pull request #1447 from takiy33/patch-1
Remove duplicate after hook
83d000b
Commits on Jul 22, 2015
@egwspiti egwspiti singleline rescue should not change indentation. 4156c44
Commits on Jul 24, 2015
@strcmp strcmp fix #1407 0a84449
@strcmp strcmp update CHANGELOG.md [ci skip] 3224e41
Commits on Jul 27, 2015
@strcmp strcmp cleanup after fix for #1407 7035f61
@strcmp strcmp add ReservedKeyError; reserve more keys. c49d031
@strcmp strcmp add API docs; remove old 'refresh' alias. 39bbfa9
@strcmp strcmp reference bug # in spec. 41d8e86
Commits on Jul 28, 2015
@strcmp strcmp update CHANGELOG.md [ci skip] a24a7c7
@strcmp strcmp add API docs for Pry::Config; fix pretty_print on Pry::Config.
[ci skip]
2158f27
@strcmp strcmp finish API docs for Pry::Config::Behavior. [ci skip] e295cf4
@strcmp strcmp API doc fixes [ci skip] c2169eb
Commits on Aug 03, 2015
@strcmp strcmp Merge pull request #1451 from egwspiti/master
singleline rescue should not change indentation.
47f8a1d
@strcmp strcmp update CHANGELOG.md [ci skip] 8a932c7