Ensure pry --simple-prompt (and other flags) gets precedence over prompt defined in .pryrc #670

Closed
robin850 opened this Issue Jul 25, 2012 · 3 comments

Comments

Projects
None yet
4 participants
@robin850

Hello,

related to #667. I just open this issue as a kind of reminder in order to improve the pry configuration.

cc @banister

Thank you, have a nice day. :)

EDIT: as stated by @kyrylo below, this applies to all our flags (including --no-color). Pry executable flags should override settings in .pryrc (but they currently do not)

@robin850

This comment has been minimized.

Show comment
Hide comment
@robin850

robin850 Jul 26, 2012

Why not create a predicate method like rc_loaded? which return the value of an accessor like rc_loaded. Then edit the load_rc method to set a value on the previous accessor (true if it's correctly loaded and false if it isn't). Finally, do the same for the local rc files.

If this solution looks good, I can eventually submit a pull request if you want ?

Why not create a predicate method like rc_loaded? which return the value of an accessor like rc_loaded. Then edit the load_rc method to set a value on the previous accessor (true if it's correctly loaded and false if it isn't). Finally, do the same for the local rc files.

If this solution looks good, I can eventually submit a pull request if you want ?

@kyrylo

This comment has been minimized.

Show comment
Hide comment
@kyrylo

kyrylo Aug 26, 2012

Member

That is probably a duplicate: #693

Member

kyrylo commented Aug 26, 2012

That is probably a duplicate: #693

@rf- rf- removed this from the 0.9.11 milestone Apr 29, 2014

@rf- rf- added the bug label Apr 29, 2014

@richo

This comment has been minimized.

Show comment
Hide comment
@richo

richo Mar 26, 2015

Contributor

This should be able to be closed now.

Contributor

richo commented Mar 26, 2015

This should be able to be closed now.

@kyrylo kyrylo closed this Mar 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment