Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bond's file autocompletion is broken #807

Closed
kyrylo opened this Issue Jan 14, 2013 · 7 comments

Comments

Projects
None yet
4 participants
Owner

kyrylo commented Jan 14, 2013

Tested on

  • jruby 1.7.0 (1.9.3p203) 2012-10-22 ff1ebbe on OpenJDK Server VM 1.7.0_09-b30 [linux-i386]
  • rubinius 2.0.0rc1 (1.8.7 release 2012-11-02 JI) [i686-pc-linux-gnu]

http://showterm.io/fe44b40bcd867cdde757a

Contributor

Trevoke commented Nov 17, 2013

This is what I'm getting right now, with plain jruby-1-7-8 installed via RVM on OSX 10.9, and only the two gems pry and bond installed. Note that like @kyrylo I typed something after "edit" but it disappeared. I'll have to examine bond itself next.

% pry
Error loading ~/.pryrc: no such file to load -- interactive_editor
org/jruby/RubyKernel.java:1084:in `require'
Bond Error: Failed Jruby setup with 'missing class or uppercase package name (`org.jruby.ext.Readline')'
[1] pry(main)> require 'readline'
=> false
[2] pry(main)> edit
Bond Error: Failed during completion action '/\A/' with 'uninitialized constant Readline::FILENAME_COMPLETION_PROC'.
Completion Info: Matches completion with condition /\A/.
[2] pry(main)>
Contributor

Trevoke commented Nov 26, 2013

I think we might be waiting on bond to fix some issues on their own. I'll take some time to do a clone and accept some pull requests to see if any of them fix this issue or get us moving forward with it.
In particular, cldwalker/bond#35 seems promising.

Owner

ConradIrwin commented Nov 26, 2013

At this point we should probably just fork it, and/or bring everything in house.

The code that we get to share by using it is OK, but the structure is a bit different to what we actually want so it's a bit fragile the way we're currently integrated.

Contributor

Trevoke commented Nov 26, 2013

I'll look into that as well, then :)

Owner

kyrylo commented Nov 26, 2013

@ConradIrwin, do you mean, we should use so-called Bond missions?

Contributor

Trevoke commented Dec 3, 2013

I'm going to try and bring the benefits that Bond brings to pry into pry itself so we lose the dependency. Any ideas where I should start looking, or any weird gotchas I should look out for?

Owner

rf- commented Apr 29, 2014

Bond support is in a plugin now, so I'm going to close this. Improvements to the built-in autocomplete are definitely still welcome though.

@rf- rf- closed this Apr 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment