Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Making Pry Coolline agnostic #833

Open
Mon-Ouie opened this Issue · 5 comments

4 participants

@Mon-Ouie
Collaborator

When I wanted to make Pry use Coolline, for some reason I made Pry special case Coolline.

Now that I think of it, that's kind of stupid. Pry shouldn't need to know about Coolline. Instead, one can easily create a wrapper that behaves as the input object expected by Pry, as here: pry/pry-coolline@e1f67f1

I think removing explicit handling of Coolline (and, ideally, any other input source) would be a good idea.

@kyrylo
Collaborator

@Mon-Ouie, do you plan to work on this in the near future?

@Mon-Ouie
Collaborator

Not really, no.

@epitron
Collaborator

This is probably a good thing to revisit, since Pry's internals are being refactored for remote APIs.

@kyrylo
Collaborator

@rf- removed Coolline special cases from the code in one of the branches.

P.S. Sorry for closing this; GitHub's mobile interface is not very polished.

@kyrylo kyrylo closed this
@kyrylo kyrylo reopened this
@rf- rf- added this to the v1.0.0 milestone
@rf- rf- added the feature label
@kyrylo
Collaborator

This commit apparently fixes it: 30c1c8e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.