Making Pry Coolline agnostic #833

Open
Mon-Ouie opened this Issue Jan 27, 2013 · 5 comments

Comments

Projects
None yet
4 participants
Member

Mon-Ouie commented Jan 27, 2013

When I wanted to make Pry use Coolline, for some reason I made Pry special case Coolline.

Now that I think of it, that's kind of stupid. Pry shouldn't need to know about Coolline. Instead, one can easily create a wrapper that behaves as the input object expected by Pry, as here: pry/pry-coolline@e1f67f1

I think removing explicit handling of Coolline (and, ideally, any other input source) would be a good idea.

Owner

kyrylo commented Mar 14, 2013

@Mon-Ouie, do you plan to work on this in the near future?

Member

Mon-Ouie commented Mar 15, 2013

Not really, no.

Member

epitron commented Nov 27, 2013

This is probably a good thing to revisit, since Pry's internals are being refactored for remote APIs.

Owner

kyrylo commented Nov 27, 2013

@rf- removed Coolline special cases from the code in one of the branches.

P.S. Sorry for closing this; GitHub's mobile interface is not very polished.

@kyrylo kyrylo closed this Nov 27, 2013

@kyrylo kyrylo reopened this Nov 27, 2013

@rf- rf- added this to the v1.0.0 milestone Apr 29, 2014

@rf- rf- added the feature label Apr 29, 2014

Owner

kyrylo commented Mar 4, 2015

This commit apparently fixes it: 30c1c8e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment