Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a landing page, with a link to metrics. to make it more in line… #100

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
4 participants
@cybervedaa
Copy link

commented Apr 26, 2019

added a landing page, with a link to metrics. to make it more in line like other prometheus exporters

As discussed here #99 (comment)

Vedavyas Kadudas Vedavyas Kadudas
@codecov-io

This comment has been minimized.

Copy link

commented Apr 26, 2019

Codecov Report

Merging #100 into master will decrease coverage by 0.44%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #100      +/-   ##
=========================================
- Coverage   91.64%   91.2%   -0.45%     
=========================================
  Files           4       4              
  Lines         455     466      +11     
=========================================
+ Hits          417     425       +8     
- Misses         38      41       +3
Impacted Files Coverage Δ
vmware_exporter/vmware_exporter.py 91.09% <72.72%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 679e6e4...3f46920. Read the comment docs.

@pryorda

This comment has been minimized.

Copy link
Owner

commented May 7, 2019

Could you add a test for this please?

Vedavyas Kadudas added some commits May 9, 2019

@cybervedaa

This comment has been minimized.

Copy link
Author

commented May 9, 2019

@pryorda - as requested, i have added a test case. please check and let me know if it looks ok.

@pryorda pryorda self-requested a review May 10, 2019

@pryorda
Copy link
Owner

left a comment

LGTM. Great work. I have another change that I would like to get out before this, but this will be merged soon.

@kremers

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

@cybervedaa can you rebase the change?

@kremers

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

Updated the PR in #108

@pryorda pryorda closed this May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.