Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #113 VM and VMGuest Metrics field errors if no access to list VCenter Hosts #115

Merged
merged 2 commits into from Jun 4, 2019

Conversation

Projects
None yet
3 participants
@kremers
Copy link
Contributor

commented May 31, 2019

see: #113

kremers added some commits May 29, 2019

Added test showing the metrics problem with different access privs
Signed-off-by: Martin Kremers <info@martinkremers.de>
fix(wrong labels): restricted access user resultet in wrong labeling
Signed-off-by: Martin Kremers <info@martinkremers.de>

Precommit-Verified: 2c286246f4ed6f28b351d7ee9e2966f72d21bfe407f3b7f5a303e1271633fb71
@codecov-io

This comment has been minimized.

Copy link

commented May 31, 2019

Codecov Report

Merging #115 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage      92%   92.09%   +0.09%     
==========================================
  Files           4        4              
  Lines         500      506       +6     
==========================================
+ Hits          460      466       +6     
  Misses         40       40
Impacted Files Coverage Δ
vmware_exporter/vmware_exporter.py 92.12% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68db001...636b69d. Read the comment docs.

@pryorda

pryorda approved these changes Jun 3, 2019

Copy link
Owner

left a comment

lgtm

@pryorda pryorda merged commit a1bb45a into pryorda:master Jun 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - requirements.txt (pryorda) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.