Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove float64 usage for fork choice #9438

Merged
merged 1 commit into from Aug 20, 2021
Merged

Conversation

terencechain
Copy link
Member

Description

Remove float64 usage for protoarray forkchoice's apply weight changes

@terencechain terencechain added the Ready For Review A pull request ready for code review label Aug 20, 2021
@terencechain terencechain self-assigned this Aug 20, 2021
@terencechain terencechain requested a review from a team as a code owner August 20, 2021 18:04
@terencechain terencechain requested review from kasey, rkapka and nisdas and removed request for a team August 20, 2021 18:04
@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #9438 (0187662) into develop (25bc3f2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #9438      +/-   ##
===========================================
- Coverage    60.37%   60.36%   -0.02%     
===========================================
  Files          580      580              
  Lines        42770    42773       +3     
===========================================
- Hits         25822    25818       -4     
- Misses       13072    13076       +4     
- Partials      3876     3879       +3     

@rauljordan rauljordan merged commit 005ce7e into develop Aug 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the forkchoice-precision branch August 20, 2021 19:15
prestonvanloon pushed a commit that referenced this pull request Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants