Use Start Index Flag in Unencrypted Key Gen #3506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
requested review from
terencechain,
0xKiwi,
nisdas,
prestonvanloon and
shayzluf
prestonvanloon
previously approved these changes
Sep 17, 2019
terencechain
previously approved these changes
Sep 17, 2019
nisdas
previously approved these changes
Sep 18, 2019
rauljordan
dismissed stale reviews from nisdas, terencechain, and prestonvanloon
via
e12569b
prestonvanloon
approved these changes
Sep 18, 2019
terencechain
approved these changes
Sep 18, 2019
Codecov Report
@@ Coverage Diff @@
## master #3506 +/- ##
========================================
Coverage ? 1.33%
========================================
Files ? 40
Lines ? 2987
Branches ? 0
========================================
Hits ? 40
Misses ? 2941
Partials ? 6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unencrypted-key-gen under //tools uses a deterministic algorithm for key generation. However, if I want to generate 32 keys and then another 32 unique keys, I need a way to specify the start index of the algorithm via a flag. This PR adds that functionality.