Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Validator Exits #6986

Merged
merged 3 commits into from Aug 13, 2020
Merged

Fix Validator Exits #6986

merged 3 commits into from Aug 13, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Aug 13, 2020

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

  • Adds the spec's pre-conditions for exits so as to properly verify them without validating their singatures.
  • Adds the conformance checks in tests to ensure both methods do not diverge from each other(excluding signature
    verification).

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner Aug 13, 2020
@nisdas nisdas requested review from farazdagi, shayzluf and 0xKiwi Aug 13, 2020
@nisdas nisdas added the Ready For Review A pull request ready for code review label Aug 13, 2020
beacon-chain/core/blocks/exit.go Outdated Show resolved Hide resolved
Co-authored-by: Shay Zluf <thezluf@gmail.com>
@terencechain terencechain added the OK to merge Bulldozer will merge this if approved and all checks pass label Aug 13, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit 72bbc33 into master Aug 13, 2020
16 checks passed
@nisdas nisdas deleted the fixExits branch Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OK to merge Bulldozer will merge this if approved and all checks pass Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants