Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzz: sigp/beaconfuzz#78 #7684

Merged
merged 6 commits into from Oct 30, 2020
Merged

Fuzz: sigp/beaconfuzz#78 #7684

merged 6 commits into from Oct 30, 2020

Conversation

prestonvanloon
Copy link
Member

@prestonvanloon prestonvanloon commented Oct 30, 2020

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

Beaconfuzz discovered an off by one issue where an attestation could be produced which would pass
validation when att.Data.CommitteeIndex is 1 and the committee count per slot is also 1. The only
valid att.Data.Committee index would be 0, so this is an off by one error.
See: sigp/beacon-fuzz#78

Which issues(s) does this PR fix?

Fixes sigp/beacon-fuzz#78

Other notes for review

@prestonvanloon prestonvanloon marked this pull request as ready for review October 30, 2020 01:48
@prestonvanloon prestonvanloon requested a review from a team as a code owner October 30, 2020 01:48
@prestonvanloon prestonvanloon added Bug Something isn't working Fuzz Anything fuzz testing related! Ready For Review A pull request ready for code review labels Oct 30, 2020
terencechain
terencechain previously approved these changes Oct 30, 2020
@prestonvanloon prestonvanloon added the OK to merge Bulldozer will merge this if approved and all checks pass label Oct 30, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit 99f1594 into master Oct 30, 2020
13 checks passed
@delete-merged-branch delete-merged-branch bot deleted the beaconfuzz-issue-78 branch October 30, 2020 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Fuzz Anything fuzz testing related! OK to merge Bulldozer will merge this if approved and all checks pass Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FUZZ] Beaconfuzz_v2 crash-04bf9c907f05466a1bf0d9f203f30dacb2f19703 in attestation
2 participants