Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzz: sigp/beaconfuzz#91 #7725

Merged
merged 1 commit into from Nov 4, 2020
Merged

Fuzz: sigp/beaconfuzz#91 #7725

merged 1 commit into from Nov 4, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Nov 4, 2020

What type of PR is this?

Core Code Fix

What does this PR do? Why is it needed?

Beaconfuzz discovered that we used an incorrect epoch when validating the slashing. We would
use the proposer_slashing's epoch instead of the current epoch in the beacon state.

  • Use correct value to validate proposer slashings.
  • Add in regression test.

Which issues(s) does this PR fix?

Fixes this issue:
sigp/beacon-fuzz#91

Other notes for review

@nisdas nisdas requested a review from a team as a code owner November 4, 2020 12:30
@nisdas nisdas added Fuzz Anything fuzz testing related! Bug Something isn't working OK to merge Bulldozer will merge this if approved and all checks pass Priority: Critical Highest, immediate priority item labels Nov 4, 2020
@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #7725 into master will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7725      +/-   ##
==========================================
- Coverage   62.10%   61.94%   -0.17%     
==========================================
  Files         429      427       -2     
  Lines       30438    30006     -432     
==========================================
- Hits        18905    18587     -318     
+ Misses       8582     8502      -80     
+ Partials     2951     2917      -34     

Copy link
Contributor

@shayzluf shayzluf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prylabs-bulldozer prylabs-bulldozer bot merged commit 8661eb3 into master Nov 4, 2020
14 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fixSlashingValidation branch November 4, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Fuzz Anything fuzz testing related! OK to merge Bulldozer will merge this if approved and all checks pass Priority: Critical Highest, immediate priority item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants