Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Effective Balance Calculation #8743

Merged
merged 9 commits into from Apr 13, 2021

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Apr 12, 2021

What type of PR is this?

Core Code Improvement

What does this PR do? Why is it needed?

  • This simplifies an effective balance calculation, by only writing in a new validator copy if the effective balance has
    actually changed.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas added the Ready For Review A pull request ready for code review label Apr 12, 2021
@nisdas nisdas added this to the v1.3.8 milestone Apr 12, 2021
@nisdas nisdas requested a review from a team as a code owner April 12, 2021 09:30
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #8743 (aa9231e) into develop (5f3299e) will decrease coverage by 0.67%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #8743      +/-   ##
===========================================
- Coverage    61.61%   60.94%   -0.68%     
===========================================
  Files          509      509              
  Lines        34791    34760      -31     
===========================================
- Hits         21436    21183     -253     
- Misses       10179    10444     +265     
+ Partials      3176     3133      -43     

Copy link
Contributor

@farazdagi farazdagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice optimization!

@prylabs-bulldozer prylabs-bulldozer bot merged commit 45d2df1 into develop Apr 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the improveEffectiveBalanceCalc branch April 13, 2021 12:44
nisdas added a commit that referenced this pull request Apr 30, 2021
prestonvanloon pushed a commit that referenced this pull request May 1, 2021
* Revert "Simplify Effective Balance Calculation (#8743)"

This reverts commit 45d2df1.

* add flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants