Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate Proto V2 Namespace #9297

Merged
merged 6 commits into from Jul 28, 2021
Merged

Eliminate Proto V2 Namespace #9297

merged 6 commits into from Jul 28, 2021

Conversation

rauljordan
Copy link
Contributor

Follow-up to #9296, this PR gets rid of the v2 namespace in Prysm

@rauljordan rauljordan requested a review from a team as a code owner July 28, 2021 19:34
@rauljordan rauljordan requested review from jmozah, rkapka and nisdas and removed request for a team July 28, 2021 19:34
@rauljordan rauljordan added Ready For Review A pull request ready for code review OK to merge labels Jul 28, 2021
@codecov
Copy link

codecov bot commented Jul 28, 2021 •
edited

Codecov Report

Merging #9297 (5c31949) into develop (f16b985) will increase coverage by 1.67%.
The diff coverage is 33.33%.

❗ Current head 5c31949 differs from pull request most recent head d6d0f35. Consider uploading reports for the commit d6d0f35 to get more accurate results

@@             Coverage Diff             @@
##           develop    #9297      +/-   ##
===========================================
+ Coverage    58.54%   60.22%   +1.67%     
===========================================
  Files          568      567       -1     
  Lines        41538    42008     +470     
===========================================
+ Hits         24319    25299     +980     
+ Misses       13653    12977     -676     
- Partials      3566     3732     +166

terencechain
terencechain reviewed Jul 28, 2021
View reviewed changes
beacon-chain/db/kv/blocks_test.go Outdated Show resolved Hide resolved
beacon-chain/rpc/prysm/v1alpha1/validator/attester_test.go Outdated Show resolved Hide resolved
beacon-chain/sync/pending_blocks_queue_test.go Outdated Show resolved Hide resolved
beacon-chain/p2p/testing/p2p.go Outdated Show resolved Hide resolved
beacon-chain/p2p/utils.go Outdated Show resolved Hide resolved
beacon-chain/p2p/peers/peerdata/store.go Outdated Show resolved Hide resolved
beacon-chain/p2p/peers/status.go Outdated Show resolved Hide resolved
beacon-chain/p2p/service.go Outdated Show resolved Hide resolved
beacon-chain/p2p/testing/fuzz_p2p.go Outdated Show resolved Hide resolved
beacon-chain/p2p/testing/mock_metadataprovider.go Outdated Show resolved Hide resolved
@prylabs-bulldozer prylabs-bulldozer bot merged commit 9145310 into develop Jul 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the remove-v2 branch July 28, 2021 21:23
@terencechain terencechain mentioned this pull request Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain approved these changes

@jmozah jmozah Awaiting requested review from jmozah

@rkapka rkapka Awaiting requested review from rkapka

@nisdas nisdas Awaiting requested review from nisdas

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rauljordan @terencechain