Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth2 api: use balance instead of effective balance #9722

Merged
merged 3 commits into from Oct 4, 2021

Conversation

terencechain
Copy link
Member

Fixes #9721

Use balance instead of effective balance for /eth/v1/beacon/states/{state_id}/validators and /eth/v1/beacon/states/{state_id}/validator_balances end points

@terencechain terencechain added the Ready For Review A pull request ready for code review label Oct 2, 2021
@terencechain terencechain self-assigned this Oct 2, 2021
@terencechain terencechain requested a review from a team as a code owner October 2, 2021 18:47
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add regression test

@prylabs-bulldozer prylabs-bulldozer bot merged commit 644038b into develop Oct 4, 2021
@nisdas nisdas deleted the use-correct-balance branch April 15, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid validator balances for v1 endpoints
3 participants