Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Doppelganger Protection #9748

Merged
merged 9 commits into from Oct 18, 2021
Merged

Fix Doppelganger Protection #9748

merged 9 commits into from Oct 18, 2021

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Oct 7, 2021 •
edited

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

  • Removes false positives that came up when using doppelganger protection.
  • Fix tests

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas marked this pull request as ready for review October 15, 2021 14:15
@nisdas nisdas requested a review from a team as a code owner October 15, 2021 14:15
@nisdas nisdas added the Ready For Review A pull request ready for code review label Oct 15, 2021
@rauljordan
Copy link
Contributor

Tests still failing

@prylabs-bulldozer prylabs-bulldozer bot merged commit bfcb113 into develop Oct 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the doppelGangerFix branch October 18, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@terencechain terencechain Awaiting requested review from terencechain terencechain is a code owner automatically assigned from prysmaticlabs/core-team

@rkapka rkapka Awaiting requested review from rkapka rkapka is a code owner automatically assigned from prysmaticlabs/core-team

@james-prysm james-prysm Awaiting requested review from james-prysm james-prysm is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nisdas @rauljordan @rkapka