Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BeepConfig command support, miscellaneous beep related cleanup #524

Merged
merged 2 commits into from May 14, 2019

Conversation

Projects
None yet
2 participants
@itsmojo
Copy link

commented May 13, 2019

No description provided.

@ps2
Copy link
Owner

left a comment

Looks good! Just one recommendation; MessageBlocks should use the decoded types as their members, and encode/decode when serializing or deserializing.

@ps2 ps2 merged commit 830934f into ps2:omnipod-testing May 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@itsmojo itsmojo deleted the itsmojo:add-beep-config-command branch May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.