Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

game menu: add default global config for game settings #232

Closed
wants to merge 3 commits into from

Conversation

@KrahJohlito
Copy link
Contributor

@KrahJohlito KrahJohlito commented Oct 29, 2019

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK
  • Requires update of the gsKit
  • Others (please specify below)

Pull Request description

Add a global config for game settings (conf_game.cfg) this allows the user to choose between loading per game or global settings on a game by game/feature by feature basis.. global config is used by default and supports GSM, Cheats & PADEMU... per game settings take precedence over global if selected.

For a simple breakdown of how it works see here:
https://www.psx-place.com/threads/open-ps2-loader-v0-9-3.13415/page-45#post-211808

Test Build
https://www.sendspace.com/file/g9vqsx

@J013k
Copy link
Contributor

@J013k J013k commented Oct 29, 2019

Here is also little preview of updated main Game menu GUI:
https://i.postimg.cc/WbJvNfx4/Game-memu-GUI-2.png

@BatRastard
Copy link
Contributor

@BatRastard BatRastard commented Oct 30, 2019

Just compiled r1399 on my end and like it alot. :D

Alas, I need a replacement Controller/MC slot bay for my Fat PS2. Controller lag and PMC detection issues are happening way too often to ignore any further.

@KrahJohlito
Copy link
Contributor Author

@KrahJohlito KrahJohlito commented Nov 1, 2019

Added a quick fix for VMC GUI, commit message explains it... the issue was present in previous builds which is why it carried over to the new Game Menu.

Also I gotta agree with @TnA-Plastic on this one, the UseInfoPage option is redundant now as it is always an option by choosing to press square or not before booting a game so having the toggle switch only confuses noobies.

Unfortunately without write access I'm having difficulty finding the merge conflict.. it is neither present on my local nor my fork and git says I'm all up to date but if you can show me the file(s)/conflict(s) I can show how it should be.

Best Regards.

@TnA-Plastic
Copy link

@TnA-Plastic TnA-Plastic commented Nov 1, 2019

Regarding a 'switch' to turn Info-Page on and off:
Yes, I think that is a redundant choice now! ;)

I can see only ONE reason FOR that switch, which would be the case if some theme intentionally wants to disable the Info-Page, but even then the 'switch' should reside in the Theme-Config and not in OPL's config!

Why?
First off for what @KrahJohlito mentioned (preventing confusion on the user-side) and second, it wouldn't limit users to change the function back&forth for various themes, but one theme could have an Info-Page (even if it doesn't have additional support in the cfg/scripts or no special textures for it) and another theme could have it intentionally disabled.
This would trim down user-interaction to only changing a theme, instead of changing a theme and then additionally the Info-Page-switch/setting.

So I opt for not totally removing it, but introduce the switch to the Theme-Config instead.

Old Themes could default to 'Info-Page=1', even if it is not present in the config (thus keeping compatibility to old themes, while they get support for the Info-Page) and if a theme-creator wants to intentionally block the page, he/she could add 'Info-Page=0' to his config! :)

@Tupakaveli
Copy link
Contributor

@Tupakaveli Tupakaveli commented Nov 1, 2019

If you don't want your custom theme to have an info page all you have to do is not add an "info0:" element to the conf_theme.cfg

@TnA-Plastic
Copy link

@TnA-Plastic TnA-Plastic commented Nov 1, 2019

Yes, but the (vice-versa-)way I described it, we would have support for Info-Page on every theme out there - even without adding anything to any (theme-)config - and only disable it, if it were really wanted/needed. ;)

@KrahJohlito
Copy link
Contributor Author

@KrahJohlito KrahJohlito commented Nov 1, 2019

It already does that how @Tupakaveli explained, themes that support info pages will have info elements where as themes that people made not to support the info will only have main elements, you can’t switch to the info page if there are no info elements in your loaded theme. :)

@TnA-Plastic
Copy link

@TnA-Plastic TnA-Plastic commented Nov 1, 2019

That's why I also mentioned elsewhere, that I think the internal theme should have some basic info-page-support, so it can be used on themes which were not updated to include info-page-support...

I don't see, why any theme would not have the Info-Page, except for the textures/style of the integrated theme's Info-Page not aligning well with the style of the chosen theme.

@KrahJohlito
Copy link
Contributor Author

@KrahJohlito KrahJohlito commented Nov 1, 2019

Ifcaro has had a default internal info page for like over a year or something now, but I think option wise it’s better as is in this PR... all the current themes with no info elems were intended not to use an info page, if we add that theme cfg option they would all need to go back and edit their cfgs to add infopage=0.. where as this way it’s automatic.

@ElPatas1
Copy link
Collaborator

@ElPatas1 ElPatas1 commented Nov 1, 2019

Hello,

this branch has conflicts and the commits cannot be merged.

Best regards.

@Jay-Jay-OPL
Copy link
Contributor

@Jay-Jay-OPL Jay-Jay-OPL commented Nov 2, 2019

I also think a default info page would not be good idea, because then it forces the theme creator to have to build one, even though his original intent was not to support one for his custom theme.

Plus now that we can even add more elements on the MAIN page (recent fix by krah), well, there might be some new upcoming custom themes where everything (or most elements) are on the first main page.

I think the way it is now, works great. And plus removing the redundant option of turning on/off the info page in the settings is also perfect.

Like it was said above, if the custom theme artist adds the properties that start to display the info page in the theme's CFG file, then it should show, if not, then it shouldn't show, this way to avoid a default info page that doesn't even look like it's completed or matches the custom theme's layout.

My .02 cents.

@KrahJohlito KrahJohlito closed this Nov 2, 2019
@KrahJohlito
Copy link
Contributor Author

@KrahJohlito KrahJohlito commented Nov 2, 2019

@ElPatas1
Sorry I'm not sure what happened exactly as I couldn't find any conflicts on my end.. had to issue a new PR.

Plus now that we can even add more elements on the MAIN page (recent fix by krah)

That was other contributors, Maximus32 fixed main10 bug and Tupakaveli added support for attribute images/txt on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.