VU0MixVec only flush used registers #278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
I did some more research this morning and realized that the
"memory"clobber flushed all of the registers. The gcc documentation recommends listing additional inputs/outputs for the accessed memory and this is the approach I took. Technically all the used registers should be listed as scratch registers so that gcc knows not to use them but I could not get it to accept any of the register namesa0, $a0, etcit would only accept 0-64. AFAIK gcc cannot use the v0 vector registers directly anyway so I don't think there will be an issue. If any problems ever arise then we can fallback to the"memory"clobber.Here is the gcc documentation https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html#Clobbers-and-Scratch-Registers