New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language Update #494
Merged
Merged
Language Update #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused strings and hardcode some that don't need translation
2 tasks
AKuHAK
pushed a commit
to AKuHAK/Open-PS2-Loader-history
that referenced
this issue
Sep 30, 2021
Language Update
AKuHAK
pushed a commit
to AKuHAK/Open-PS2-Loader-history
that referenced
this issue
Sep 30, 2021
Language Update
AKuHAK
pushed a commit
to AKuHAK/Open-PS2-Loader-history
that referenced
this issue
Oct 3, 2021
Language Update
AKuHAK
pushed a commit
to AKuHAK/Open-PS2-Loader-history
that referenced
this issue
Oct 3, 2021
Language Update
AKuHAK
pushed a commit
to AKuHAK/Open-PS2-Loader-history
that referenced
this issue
Oct 3, 2021
Language Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Pull Request checklist
Note: these are not necessarily requirements
- Requires update of language files
Pull Request description
This closes #487 and is admittedly quite destructive to the language files but a clean up was due, I'm hoping @J013k is able to follow up this PR with an update to external language files.
A bunch of unused strings removed, some hard coded since they don't need translation, some new added for hints.. removed all instances of Enable/Disable since they are redundant when the options are ON/OFF. Users take note that Debug Colors & Fake DS3 Workaround will now be reversed.. ie ON does not disable the feature.
Slight clean up to notifications and the addition of one more to display which hdd partition has been mounted at boot up.
Thanks to @J013k for helping out.