Permalink
Browse files

Retain compatibility with existing plugins.

  • Loading branch information...
1 parent c56f3de commit fbe0226698583e8287e66cc0edb8418a540a7c46 @Raptor399 Raptor399 committed Nov 2, 2012
Showing with 3 additions and 1 deletion.
  1. +3 −1 src/main/java/net/pms/encoders/Player.java
@@ -65,7 +65,9 @@
*
* @return The shortened name.
*/
- public abstract String getShortName();
+ public String getShortName() {
+ return name();
+ }
public abstract int type();

3 comments on commit fbe0226

Owner

chocolateboy replied Nov 2, 2012

This method is still a bad idea for the reasons I outlined.

I repeat: what is the actual limitation this is addressing? Which renderer? What is the maximum number of characters it can display for a filename? If the constraint can be met by the other abbreviations (or by hiding the engine name) then this hack is not needed. Even if it's not met, the hack can be isolated (by implementing a private abbreviation method in DLNAResource) without contaminating the engine API.

It is not part of an engine's contract to expose an identifier that accommodates the undocumented limitation of one renderer. Adding a completely unrelated method to the engine base class is exactly the kind of tightly-coupled legacy hack we're trying to deprecate and remove.

Owner

chocolateboy replied Nov 2, 2012

Fixed in 510529e.

Member

Raptor399 replied Nov 3, 2012

Ah, I now understand that you're on about the very existence of the method.
Your fix is fine with me, thanks.

Please sign in to comment.