Detect embedded ASS/SSA subtitles (thanks leroy!) #12

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

Embedded ASS/SSA subtitles were being ignored during the check for embedded subtitles. As a result, under certain circumstances videos with ASS/SSA subtitles would forego transcoding. See this post.

It turns out that embedded ASS/SSA subtitles are not given the "embedded" type like other embedded subtitles. They are explicitly checked for and now detect properly for both the embedded and external case.

Detect embedded ASS/SSA subtitles (thanks leroy!)
Embedded ASS/SSA subtitles were being ignored during the check for
embedded subtitles. They will now detect properly.
Member

Raptor399 commented Jan 30, 2012

Good catch!

I'm not going to use the code in this pull request, as I think the logic in determining whether or not the subs are embedded should lie inside DLNAMediaSubtitle. Changed patch committed in 8d3f0de.

@Raptor399 Raptor399 closed this Jan 30, 2012

True, there is already too much loose code lying around. I do like :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment