GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Embedded ASS/SSA subtitles were being ignored during the check for embedded subtitles. As a result, under certain circumstances videos with ASS/SSA subtitles would forego transcoding. See this post.
It turns out that embedded ASS/SSA subtitles are not given the "embedded" type like other embedded subtitles. They are explicitly checked for and now detect properly for both the embedded and external case.
Detect embedded ASS/SSA subtitles (thanks leroy!)
Embedded ASS/SSA subtitles were being ignored during the check for
embedded subtitles. They will now detect properly.
I'm not going to use the code in this pull request, as I think the logic in determining whether or not the subs are embedded should lie inside DLNAMediaSubtitle. Changed patch committed in 8d3f0de.
True, there is already too much loose code lying around. I do like :)