Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Force language because JUnit tests depend on english language strings #45

Merged
merged 1 commit into from May 6, 2012

Conversation

Projects
None yet
2 participants
Contributor

smmmo commented May 6, 2012

  • Fix in pom.xml to fix build for non-english environments (e.g. german)
  • Fix in RendererConfigurationTest.java for running JUnit tests in eclipse

Error message from failed maven build:

[...]
Running net.pms.test.RendererConfigurationTest
Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.068 sec <<< FAILURE!

Results :

Failed tests: testBogusDefault(net.pms.test.RendererConfigurationTest): Expected renderer "Unknown renderer", instead renderer "Unbekannter DLNA Client" was returned for header "User-Agent: AirPlayer/1.0.09 CFNetwork/485.13.9 Darwin/11.0.0" expected:<Un[known renderer]> but was:<Un[bekannter DLNA Client]>
[...]

Member

Raptor399 commented May 6, 2012

Nicely spotted, thanks!

@Raptor399 Raptor399 added a commit that referenced this pull request May 6, 2012

@Raptor399 Raptor399 Merge pull request #45 from smmmo/junit_localized
Force language because JUnit tests depend on english language strings (thanks, smmmo!)
071b5e4

@Raptor399 Raptor399 merged commit 071b5e4 into ps3mediaserver:master May 6, 2012

@Raptor399 Raptor399 pushed a commit to Raptor399/ps3mediaserver that referenced this pull request Jun 24, 2012

@taconaut taconaut Merge pull request #45 from leonard84/30d9a5f77c32b42b59cc47af926c721…
…3b6137530

added missing external dependencies to pom.xml
50c44fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment