Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added Computer Shutdown folder. #6

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants
Member

Raptor399 commented Jan 1, 2012

Might be a useful addition to have the shutdown folder built in, instead of having it as a plugin.

I'm not against this idea, but :

  • instead of calling Platform.isWindows() I suggest that you should add a new method 'String[] getShutdownCommand()' to SystemUtils with custom command for windows
  • there is already a couple of code which deals with process outputs, it seems that you don't need the output of the command, so net.pms.io.Gob would simplify the code
Member

Raptor399 commented Jan 1, 2012

Good suggestions; added commits as requested.

Member

taconaut commented Jan 3, 2012

I'm fine with adding this to pms if it works (haven't tested it).
When the time comes to merge pms-mlx into the main trunk, all these features should be added as plugins though.

Member

Raptor399 commented Jan 3, 2012

If that is the case, it is smarter to implement it as a plugin in the first place and distribute that with PMS by default.
I'll close the pull request.

@Raptor399 Raptor399 closed this Jan 3, 2012

@Raptor399 Raptor399 pushed a commit to Raptor399/ps3mediaserver that referenced this pull request Apr 1, 2012

@taconaut taconaut Show all drives if no folders are configured for a file system folder
Closes #6
0953b62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment