Build tester doesn't fail when nested builds fail #57

Closed
jsnape opened this Issue Mar 1, 2013 · 1 comment

Projects

None yet

2 participants

@jsnape
Contributor
jsnape commented Mar 1, 2013

I'm just adding some tests to my fork so I can fix an issue where -whatif causes all sorts of problems but in doing so I think I've found an issue with the way the build tester works.

If a nested build fails I assume that the parent build should also fail? I have two files in my repo that show this isn't the case:

So I'm happy to fix this before I send a pull request but not sure if its a problem with the build tester

$psake.run_by_psake_build_tester = $true

or the part of psake.psm1 which ignores the nested scope due to the build tester

if (!$psake.run_by_psake_build_tester)

I don't think this should be global to all psake invocations but instead something that is pushed onto the context stack. That way only the top level invocation changes its error handling in response to being run under test.

@damianh
Member
damianh commented Mar 31, 2014

Fixed via PR #59

@damianh damianh closed this Mar 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment