Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Framework function does not work #61

Closed
togakangaroo opened this Issue Mar 15, 2013 · 7 comments

Comments

Projects
None yet
3 participants

task Test {
Framework '2.0'
msbuild /version
Framework '3.5'
msbuild /version
Framework '4.0'
msbuild /version
}

all use msbuild 4.0 (my system default)

Upon further investigation, It seems like the framework might ONLY work when accepted as an invoke-psake parameter. I'm using psake for example to automate the creation of some nuget packages and need to run different compilers to generate different builds, being able to switch it up would be incredibly useful

Until it works properly the Framework function function should at least not be invokable from psake scripts

vorou commented Jan 2, 2014

It looks like this one is still an issue. On my dev machine I could use either way (Framework function or -framework command-line parameter). On build server call to Framework() is ignored, it uses msbuild 4.0 even if I put Framework('4.5.1') right before call to msbuild. It works if I pass version as command-line parameter.

By the way, how does psake determine which version of msbuild to use? It somehow decided to use 4.0 on build server and 12.0 on my machine.

Any news on this?

@damianh damianh added this to the v4.4.0 milestone Mar 31, 2014

@damianh damianh self-assigned this Mar 31, 2014

Owner

damianh commented Mar 31, 2014

@togakangaroo Cast your eye across this please #105

@damianh damianh added the Bug label Mar 31, 2014

Seems good to me but I can't check for a bit. Is there going to be a new release in nuget soon?

Owner

damianh commented Mar 31, 2014

I would like to push an update to nuget.org in the next day or so. I need
you (or someone else) to take a look at this and let me know if it works
for you else I'm probably not going to merge it for next release.

On 1 April 2014 00:12, George Mauer notifications@github.com wrote:

Seems good to me but I can't check for a bit. Is there going to be a new
release in nuget soon?

Reply to this email directly or view it on GitHubhttps://github.com/psake/psake/issues/61#issuecomment-39148903
.

Owner

damianh commented Apr 1, 2014

Thank you George, appreciate the fast feedback. :)

@damianh https://github.com/damianh confirmed, it
workshttp://screencast.com/t/4BJRfnGPTPg

Reply to this email directly or view it on
GitHubhttps://github.com/psake/psake/issues/61#issuecomment-39164377
.

@damianh damianh added a commit that referenced this issue Apr 1, 2014

@damianh damianh Merge pull request #105 from damianh/Issue-61
Fixes issue #61 - Framework function re-configures build environment.
263b35d

@damianh damianh closed this Apr 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment