TeamCity integration #15

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants
@damianh
Contributor

damianh commented Jul 9, 2011

This pull request contains the TeamCity integration as posted here http://groups.google.com/group/psake-dev/browse_thread/thread/d69eac6a38a5308e

(It also contains the 4.2 version bump from other pull request)

Please let me know if any problems.

Regards,

Damian Hickey
twitter.com/randompunter
gplus.to/damianh

damianh added some commits Apr 26, 2011

When logging the task name ( "Executing XX" ) the script detects if i…
…t is being run in TeamCity via environment variable

and will open a service message block and close at the end. This will give a nice message in TeamCity as to the current running task as well as collapsible log tree view.

More on teamcity service message blocks.
http://confluence.jetbrains.net/display/TCD65/Build+Script+Interaction+with+TeamCity#BuildScriptInteractionwithTeamCity-BlocksofServiceMessages

Signed-off-by: Damian Hickey <dhickey@gmail.com>
@lanwin

This comment has been minimized.

Show comment Hide comment
@lanwin

lanwin Jul 10, 2011

I think in general the idea is good. But i dont like that your thoughts go only in the direction which you special case is for. There are other good uses for a Write-TaskOpened and Write-TaskClosed function. In example what would work perfectly with together with the changes @whut which write something similar in pull request https://github.com/JamesKovacs/psake/pull/9 to support colored output.

lanwin commented on 26fe91d Jul 10, 2011

I think in general the idea is good. But i dont like that your thoughts go only in the direction which you special case is for. There are other good uses for a Write-TaskOpened and Write-TaskClosed function. In example what would work perfectly with together with the changes @whut which write something similar in pull request https://github.com/JamesKovacs/psake/pull/9 to support colored output.

This comment has been minimized.

Show comment Hide comment
@damianh

damianh Jul 21, 2011

Owner

But i dont like that your thoughts go only in the direction which you special case is for.

When I wrote this, there were no other cases, so I guess it is special :)

I went with the simplest thing that works and was not aware of other efforts in the logging area.

Feel free to include this the colored output work.

Owner

damianh replied Jul 21, 2011

But i dont like that your thoughts go only in the direction which you special case is for.

When I wrote this, there were no other cases, so I guess it is special :)

I went with the simplest thing that works and was not aware of other efforts in the logging area.

Feel free to include this the colored output work.

@whut

This comment has been minimized.

Show comment Hide comment
@whut

whut Aug 5, 2011

Member

There is something about integration with TeamCity in https://github.com/JamesKovacs/psake-contrib (i'm not a user of TeamCity). Maybe this work can be somehow combined with that.

Member

whut commented Aug 5, 2011

There is something about integration with TeamCity in https://github.com/JamesKovacs/psake-contrib (i'm not a user of TeamCity). Maybe this work can be somehow combined with that.

@lanwin

This comment has been minimized.

Show comment Hide comment
@lanwin

lanwin Aug 6, 2011

Member

Hmm yes there are the function which output the format teamcity needs. Whats missing in the psake core is a way to add a hook to pretask and posttask so this can be integrated by including the module.

Member

lanwin commented Aug 6, 2011

Hmm yes there are the function which output the format teamcity needs. Whats missing in the psake core is a way to add a hook to pretask and posttask so this can be integrated by including the module.

@whut

This comment has been minimized.

Show comment Hide comment
@whut

whut Aug 6, 2011

Member

There are TaskSetup and TaskTeardown functions, maybe they would be useful?

Member

whut commented Aug 6, 2011

There are TaskSetup and TaskTeardown functions, maybe they would be useful?

@lanwin

This comment has been minimized.

Show comment Hide comment
@lanwin

lanwin Aug 7, 2011

Member

What i mean is that it should be possible to hook into them without changing psake.

Member

lanwin commented Aug 7, 2011

What i mean is that it should be possible to hook into them without changing psake.

@damianh

This comment has been minimized.

Show comment Hide comment
@damianh

damianh Aug 7, 2011

Contributor

Would it also be possible to hook without changing user's build script? Not sure a user would want to use TaskSetup and TaskTeardown set up logging output for TeamCity, rather, Psake should 'detect' TeamCity via environment variable.

I agree that a more general solution is desirable :)

Contributor

damianh commented Aug 7, 2011

Would it also be possible to hook without changing user's build script? Not sure a user would want to use TaskSetup and TaskTeardown set up logging output for TeamCity, rather, Psake should 'detect' TeamCity via environment variable.

I agree that a more general solution is desirable :)

@lanwin

This comment has been minimized.

Show comment Hide comment
@lanwin

lanwin Aug 7, 2011

Member

Yep. psake provides that hooks. The psake modules can subscribe to that hooks and do something. So you could drop in the Teamcity module from contrib and it will detect Teamcity and enable the output.

Member

lanwin commented Aug 7, 2011

Yep. psake provides that hooks. The psake modules can subscribe to that hooks and do something. So you could drop in the Teamcity module from contrib and it will detect Teamcity and enable the output.

@whut

This comment has been minimized.

Show comment Hide comment
@whut

whut Feb 4, 2012

Member

Closing this pull request, as a more general solution should be prepared (using TaskSetup and TaskTeardown for example) and proposed to psake-contrib

Member

whut commented Feb 4, 2012

Closing this pull request, as a more general solution should be prepared (using TaskSetup and TaskTeardown for example) and proposed to psake-contrib

@whut whut closed this Feb 4, 2012

@damianh

This comment has been minimized.

Show comment Hide comment
@damianh

damianh Feb 10, 2012

Contributor

Ok, will look into that.

Contributor

damianh commented Feb 10, 2012

Ok, will look into that.

@damianh damianh deleted the damianh:TeamCityIntegration branch Feb 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment