Fixed bug where exit code didn't bubble when used with -File option #17

Merged
merged 1 commit into from Aug 5, 2011

Conversation

Projects
None yet
3 participants
@mboltuc
Contributor

mboltuc commented Jul 25, 2011

While trying to use TeamCity to run some of my psake tasks using the -File option, the error codes didn't bubble up. Adding $host.SetShouldExit fixed this issue for me.

@JamesKovacs JamesKovacs merged commit f8ee95a into psake:master Aug 5, 2011

@JamesKovacs

This comment has been minimized.

Show comment
Hide comment
@JamesKovacs

JamesKovacs Aug 5, 2011

Thanks for the patch.

Thanks for the patch.

@whut

This comment has been minimized.

Show comment
Hide comment
@whut

whut Oct 8, 2011

Member

Could you check if your issue still happens in newest psake? I could not reproduce your issue (I don't have TeamCity), and after merging #21 there is no host.SetShouldExit.

Member

whut commented Oct 8, 2011

Could you check if your issue still happens in newest psake? I could not reproduce your issue (I don't have TeamCity), and after merging #21 there is no host.SetShouldExit.

@mboltuc

This comment has been minimized.

Show comment
Hide comment
@mboltuc

mboltuc Oct 10, 2011

Contributor

Rafal,

Yeah I'll check it out as soon as I can. I've got a busy week this week so I probably won't get to it until next week.

Best regards,
Mark

On Oct 8, 2011, at 3:56 PM, Rafal Klysreply@reply.github.com wrote:

Could you check if your issue still happens in newest psake? I could not reproduce your issue (I don't have TeamCity), and after merging #21 there is no host.SetShouldExit.

Reply to this email directly or view it on GitHub:
#17 (comment)

Contributor

mboltuc commented Oct 10, 2011

Rafal,

Yeah I'll check it out as soon as I can. I've got a busy week this week so I probably won't get to it until next week.

Best regards,
Mark

On Oct 8, 2011, at 3:56 PM, Rafal Klysreply@reply.github.com wrote:

Could you check if your issue still happens in newest psake? I could not reproduce your issue (I don't have TeamCity), and after merging #21 there is no host.SetShouldExit.

Reply to this email directly or view it on GitHub:
#17 (comment)

@whut

This comment has been minimized.

Show comment
Hide comment
@whut

whut Nov 4, 2011

Member

Hi,

It would be great if you could check if your issue still happens in newest psake. You will probably need to use psake.cmd to run psake from TeamCity, or at least use approach shown in there

Member

whut commented Nov 4, 2011

Hi,

It would be great if you could check if your issue still happens in newest psake. You will probably need to use psake.cmd to run psake from TeamCity, or at least use approach shown in there

@whut

This comment has been minimized.

Show comment
Hide comment
@whut

whut Nov 29, 2011

Member

Whats up?

Member

whut commented Nov 29, 2011

Whats up?

@mboltuc

This comment has been minimized.

Show comment
Hide comment
@mboltuc

mboltuc Nov 30, 2011

Contributor

Hi Rafal,

I was able to test the latest psake locally with TeamCity 6.5.2. It
appears that the issue is still resolved. Sorry it took so long to get a
confirmation. Been swamped with work and family.

Thanks,
Mark

On Tue, Nov 29, 2011 at 2:21 PM, Rafal Klys <
reply@reply.github.com

wrote:

Whats up?


Reply to this email directly or view it on GitHub:
#17 (comment)

Contributor

mboltuc commented Nov 30, 2011

Hi Rafal,

I was able to test the latest psake locally with TeamCity 6.5.2. It
appears that the issue is still resolved. Sorry it took so long to get a
confirmation. Been swamped with work and family.

Thanks,
Mark

On Tue, Nov 29, 2011 at 2:21 PM, Rafal Klys <
reply@reply.github.com

wrote:

Whats up?


Reply to this email directly or view it on GitHub:
#17 (comment)

@whut

This comment has been minimized.

Show comment
Hide comment
@whut

whut Nov 30, 2011

Member

Thank you very much.

Member

whut commented Nov 30, 2011

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment