wormhole: Collect messages without using reflect package #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure does not seem to be a fault of this PR. Tests are passing locally for me. |
|
I rewrote the code to only use one type cast and make everything more readable over all. |
|
Refect isn't magic. Its a fairly normal pattern in the stdlib (e.g. |
|
Yes it isn't magic but it also should be used very sparingly. I agree to disagree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the message collection in the
waitFormethod without using thereflectpackage. We can use a type switch and copy over the field values directly and also make sure that non-pointer values or unsupported collector types return an error.This implementation uses a bit less "magic" and is more understandable in my opinion.
Supersedes #94