Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deal, use new features #117

Merged
merged 3 commits into from
Oct 7, 2021

Conversation

orsinium
Copy link
Contributor

@orsinium orsinium commented Oct 7, 2021

  1. Use deal.introspection.unwrap to extract the original function
  2. Use deal.introspection.init_all to precache contracts
  3. Use pytest.mark.skipif to explicitly skip tests if dependencies are missed.

Closes #116

@pschanely
Copy link
Owner

This is so much better! Thank you.
And +1 for the drive-by improvements along the way. :)

@pschanely pschanely merged commit 77d57a4 into pschanely:master Oct 7, 2021
@orsinium
Copy link
Contributor Author

orsinium commented Oct 8, 2021

Glad you like it :) I see there is quite a room for improvement but I'm afraid to change it too aggressively.

  1. Flake8 freaks out on the project. Flake8 is a good thing, it finds bugs.
  2. 100% migrating on pytest would simplify tests a lot. Deal had such a migration a long time ago, and it was done by a passer-by during hacktoberfest. So, maybe you can find someone who will do the same for you in this month, who knows ;)

@orsinium orsinium deleted the better-deal branch October 8, 2021 13:42
@pschanely
Copy link
Owner

These are good ideas. Filing some bugs presently!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration with deal
2 participants