Skip to content

Conversation

@NeoCat
Copy link
Contributor

@NeoCat NeoCat commented Nov 28, 2025

#2236 tried to introduce some code to avoid breaking the Serial console by malformed binary garbage, but the changes were redundant and the garbage was still printed to the console.

  • It replaced the heuristic that checked only the first 12 bytes with a full-string check, but this is as costly as a full ASCII / UTF-8 validation.
  • It added another heuristic specifically for LOGE(), but to stop logging the buffer content is sufficient.

This PR replaces heuristics with full ASCII/UTF-8 string validation.

  • By default, only ASCII printable characters are allowed.
  • Defining #define AUDIOTOOLS_METADATA_ICY_ASCII_ONLY false allows valid UTF-8 strings.

@pschatzmann pschatzmann merged commit d4bafe4 into pschatzmann:main Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants