From 0bf463b0bf90c5724079c54e325e1ce66aff308d Mon Sep 17 00:00:00 2001 From: Richard Si <63936253+ichard26@users.noreply.github.com> Date: Sat, 28 Aug 2021 14:24:00 -0400 Subject: [PATCH] Let's pin in pyproject.toml too Mostly since it's non-build-backend specific configuration and more widely standardized file. Not sure what benefits pinning in setup.cfg gives us on top of pyproject.toml but I'd rather not find out during the release that is supposed to happen today :wink: --- CHANGES.md | 2 +- pyproject.toml | 5 ++++- setup.cfg | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 19a9cd98aff..2b6b87d4e30 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -13,7 +13,7 @@ trailing comma (#2384) - Parsing support has been added for unparenthesized walruses in set literals, set comprehensions, and indices (#2447). -- Pin `setuptools-scm` dependency version (#2449) +- Pin `setuptools-scm` build-time dependency version (#2450) ### _Blackd_ diff --git a/pyproject.toml b/pyproject.toml index d085c0ddc62..30e62974475 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -23,7 +23,10 @@ extend-exclude = ''' # NOTE: You don't need this in your own Black configuration. [build-system] -requires = ["setuptools>=41.0", "setuptools-scm", "wheel"] +# We're pinning setuptools-scm to bugfix versions only because for build-time +# deps having them work on install by default is really important. Especially +# since it's hard for users to work-around the specified build requirements. +requires = ["setuptools>=41.0", "setuptools_scm~=6.0.1", "wheel"] build-backend = "setuptools.build_meta" [tool.pytest.ini_options] diff --git a/setup.cfg b/setup.cfg index 941236db390..dbd667e8f19 100644 --- a/setup.cfg +++ b/setup.cfg @@ -1,3 +1,3 @@ [options] -setup_requires = +setup_requires = setuptools_scm~=6.0.1