Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mypy[c] from 0.971 to 0.991 #3380

Merged
merged 3 commits into from Dec 10, 2022
Merged

Bump mypy[c] from 0.971 to 0.991 #3380

merged 3 commits into from Dec 10, 2022

Conversation

ichard26
Copy link
Collaborator

@ichard26 ichard26 commented Nov 13, 2022

Description

Fixes GH-3376.

Passed just fine: https://github.com/ichard26/black-mypyc-wheels/actions/runs/3452585255.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary? -> n/a
  • Add new / update outdated documentation? -> n/a

@ichard26 ichard26 added the C: packaging Installation and packaging of Black label Nov 13, 2022
CHANGES.md Outdated
Comment on lines 38 to 39
- Upgrade mypyc from `0.971` to `0.990` so mypycified _Black_ can be built on armv7
(#3380)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is really necessary, armv7 is probably very minor.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somebody asked for it so it will help some users :)

@github-actions
Copy link

github-actions bot commented Nov 13, 2022

diff-shades reports zero changes comparing this PR (29b41f5) to main (16b98ab).


What is this? | Workflow run | diff-shades documentation

@ichard26
Copy link
Collaborator Author

@isac322, I'd appreciate it if you could check out this PR and verify Black builds on your armv7 machine.

@isac322
Copy link
Contributor

isac322 commented Nov 15, 2022

@ichard26 Thanks for your work it works! btw mypy 0.991 just released

.pre-commit-config.yaml Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@JelleZijlstra JelleZijlstra changed the title Bump mypy[c] from 0.971 to 0.990 Bump mypy[c] from 0.971 to 0.991 Dec 10, 2022
@JelleZijlstra JelleZijlstra merged commit 80de237 into main Dec 10, 2022
@JelleZijlstra JelleZijlstra deleted the mypy-0.990 branch December 10, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: packaging Installation and packaging of Black
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to build mypyc enabled wheel on armv7 (32bit) machine
3 participants