Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black should use the line length suggested by PEP8 by default and optionally provide a config parameter to overwrite. #855

Closed
venthur opened this issue May 18, 2019 · 2 comments

Comments

@venthur
Copy link

commented May 18, 2019

Black should use the line length suggested by PEP8 by default and optionally provide a config parameter to overwrite.

While I understand and agree that you can do whatever you want in your project, It would probably benefit the project if the defaults sticks as closely as possible to the thing that it wants to fix (i.e. making PEP8 compliant code) -- but with an option to change it to other values.

@zsol

This comment has been minimized.

Copy link
Collaborator

commented May 18, 2019

Black implements a subset of PEP8, not all of it. Specifically, the default line length of 88 is explained in the readme and is unlikely to change at this point.

@zsol zsol closed this May 18, 2019

@venthur

This comment has been minimized.

Copy link
Author

commented May 18, 2019

Sure thing, it's your project so you can decide whatever you want. On the other hand, PEP8 is not going away anytime soon, so just wondering why you make everyone elses's live a bit harder to enforce your preferred style. I'd be nice to have an uncompromising re-formatter w/o options. You realized yourself that this one option will be debated and added an option for a different line length already.

Hopefully you'll change your mind on that sometime. Otherwise, good work with black, it is better than the alternatives already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.