Remove deprecated --py36 option #1236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianDeAnda
approved these changes
Feb 26, 2020
Collaborator
|
I agree that it's time for this, but there's a complex merge conflict now (sorry for the wait!). |
hugovk
force-pushed
the
rm-deprecated--py36
branch
from
c51c06f to
77c4fc4
Compare
hugovk
force-pushed
the
rm-deprecated--py36
branch
from
77c4fc4 to
36edb84
Compare
Contributor
Author
|
Merge conflict resolved! |
This was referenced Mar 12, 2021
jakubvalenta
added a commit
to jakubvalenta/blacken
that referenced
this pull request
Apr 5, 2021
Use the option --target-version insteead --py36, which was removed in Black 20.8b0. The option --target-version was added in Black 19.3b0, so blacken now requires at least this version of Black. See psf/black#1236
dakra
pushed a commit
to pythonic-emacs/blacken
that referenced
this pull request
Apr 5, 2021
Use the option --target-version insteead --py36, which was removed in Black 20.8b0. The option --target-version was added in Black 19.3b0, so blacken now requires at least this version of Black. See psf/black#1236
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--py36option was deprecated in Black 19.3b0 (#750):https://github.com/psf/black#193b0
It's been a year since it was deprecated, and has been deprecated in two releases (19.3b0 and 19.10b0).
Is it now time to remove the deprecation?
At least I think it would be good to remove before the non-prerelease Black release (#517), and whilst still in beta too.