Skip to content

Conversation

@ambv
Copy link
Collaborator

@ambv ambv commented May 7, 2021

It's the same code but in smaller chunks.

@ichard26 ichard26 added the skip news Pull requests that don't need a changelog entry. label May 7, 2021
@ichard26 ichard26 linked an issue May 7, 2021 that may be closed by this pull request
@ichard26 ichard26 added C: cleanup Refactoring and removing dust :) C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases labels May 7, 2021
@ichard26
Copy link
Collaborator

ichard26 commented May 7, 2021

Chatting with Cooper via IRC, they want this refactor to publicized in the CHANGELOG. I don't feel strongly, but I'm putting the idea out there. I think their rational was that this may introduce bugs and crashes so warning users (explicitly or implying) is a good idea.

@JelleZijlstra
Copy link
Collaborator

they want this refactor to publicized in the CHANGELOG

I agree. This change will likely break users who import black and use some functions. They shouldn't do that since it's undocumented and all, but the change has a reasonable chance of affecting users, so we should publicize it.

@JelleZijlstra
Copy link
Collaborator

Also, thanks @ambv for getting this done! This will make Black's code a lot easier to maintain and understand and I'm happy we're finally doing it!

@ichard26 ichard26 removed the skip news Pull requests that don't need a changelog entry. label May 7, 2021
@ambv ambv merged commit f2ea461 into master May 8, 2021
@ambv ambv deleted the code-reorg branch May 8, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C: cleanup Refactoring and removing dust :) C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Continue src/black refactoring.

4 participants