Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click 8.0 renamed its "die on LANG=C" function so we need to look for that one too #2227

Merged
merged 1 commit into from May 12, 2021

Conversation

@ambv
Copy link
Collaborator

@ambv ambv commented May 12, 2021

Fixes #566

CHANGES.md Outdated Show resolved Hide resolved
Loading
@JelleZijlstra
Copy link
Collaborator

@JelleZijlstra JelleZijlstra commented May 12, 2021

Would be nice to update click in our Pipfile so we test that this works correctly.

Loading

@ambv ambv force-pushed the patch-click8-on-python3.6 branch from 316f6b4 to 0617fb5 May 12, 2021
@ambv
Copy link
Collaborator Author

@ambv ambv commented May 12, 2021

For the time being I'd rather keep Pipfile.lock as is. Tests with Click 8.0 are passing:

❯ pytest --numprocesses=auto
=============================================================================================== test session starts ================================================================================================
platform darwin -- Python 3.6.13, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: /Users/ambv/Dropbox/Python/black, configfile: pyproject.toml
plugins: cases-3.5.0, cov-2.11.1, mock-3.6.1, xdist-2.2.1, forked-1.3.0
gw0 [208] / gw1 [208] / gw2 [208] / gw3 [208] / gw4 [208] / gw5 [208] / gw6 [208] / gw7 [208] / gw8 [208] / gw9 [208] / gw10 [208] / gw11 [208]
........................................ss................................x...xx............................................................................................................................ [ 98%]
....                                                                                                                                                                                                         [100%]
================================================================================================= warnings summary =================================================================================================
tests/test_black.py::BlackTestCase::test_docstring_no_string_normalization
tests/test_black.py::BlackTestCase::test_docstring_no_string_normalization
  <unknown>:107: DeprecationWarning: invalid escape sequence \

tests/test_black.py::BlackTestCase::test_docstring_no_string_normalization
tests/test_black.py::BlackTestCase::test_docstring_no_string_normalization
  <unknown>:113: DeprecationWarning: invalid escape sequence \

tests/test_black.py::BlackTestCase::test_docstring_no_string_normalization
tests/test_black.py::BlackTestCase::test_docstring_no_string_normalization
  <unknown>:118: DeprecationWarning: invalid escape sequence \

tests/test_blackd.py: 14 warnings
  /Users/ambv/.virtualenvs/black-3.6/lib/python3.6/site-packages/aiohttp/web_urldispatcher.py:188: DeprecationWarning: Bare functions are deprecated, use async ones
    "Bare functions are deprecated, " "use async ones", DeprecationWarning

tests/test_format.py::TestSimpleFormat::test_simple_format_15_docstring
  <unknown>:163: DeprecationWarning: invalid escape sequence \

tests/test_format.py::TestSimpleFormat::test_simple_format_15_docstring
  <unknown>:169: DeprecationWarning: invalid escape sequence \

tests/test_format.py::TestSimpleFormat::test_simple_format_15_docstring
  <unknown>:174: DeprecationWarning: invalid escape sequence \

tests/test_format.py::TestSimpleFormat::test_simple_format_15_docstring
  <unknown>:160: DeprecationWarning: invalid escape sequence \

tests/test_format.py::TestSimpleFormat::test_simple_format_15_docstring
  <unknown>:166: DeprecationWarning: invalid escape sequence \

tests/test_format.py::TestSimpleFormat::test_simple_format_15_docstring
  <unknown>:171: DeprecationWarning: invalid escape sequence \

-- Docs: https://docs.pytest.org/en/stable/warnings.html
============================================================================== 203 passed, 2 skipped, 3 xfailed, 26 warnings in 5.43s ==============================================================================

❯ python -c "import click; print(click.__version__)"
8.0.0

Loading

@ambv ambv merged commit b2ee211 into main May 12, 2021
34 checks passed
Loading
@ambv ambv deleted the patch-click8-on-python3.6 branch May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants