Move test for g:load_black to improve plugin performance #2896
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, could you add a changelog entry in the "Integrations" section? |
JelleZijlstra
reviewed
Feb 25, 2022
CHANGES.md
Outdated
| @@ -134,6 +134,7 @@ and the first release covered by our new | |||
|
|
|||
| ### Integrations | |||
|
|
|||
| - Move test to disable plugin in vim/neovim, which speeds up loading (#2896) | |||
There was a problem hiding this comment.
This is the changelog for the already released 22.1.0, move your entry to the unreleased section at line 36
ichard26
approved these changes
Mar 5, 2022
|
Thank you so much for your contribution! This project is only possible by contributions like these |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
If a vim/neovim user wishes to suppress loading the vim plugin by setting
g:load_blackin their VIMRC (for me, Arch linux automatically adds the plugin to Neovim's RTP, even though I'm not using it), the current location of the test comes after a call tohas('python3'). This adds, in my tests, between 35 and 45 ms to Vim load time (which I know isn't a lot but it's also unnecessary). Moving the call toexists('g:load_black')to before the call tohas('python3')removes this unnecessary test and speeds up loading.Here is
nvim --startuptimeoutput for the plugin as written up to loading black.vim (note the 35ms load time due to sourcing python providers):Here's
nvim --startuptimewith my PR applied (note that the python provider is not loaded):Checklist - did you ...