Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github now supports .git-blame-ignore-revs #2948

Closed
wants to merge 2 commits into from

Conversation

henrikhorluck
Copy link

@henrikhorluck henrikhorluck commented Mar 23, 2022

Description

Now reflects current state of the world.

Checklist - did you ...

  • Add a CHANGELOG entry if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@felix-hilden felix-hilden added the skip news Pull requests that don't need a changelog entry. label Mar 23, 2022
Copy link
Collaborator

@felix-hilden felix-hilden left a comment

Cool! Thanks for submitting a PR right away 👌 Although there still is a warning about it being beta and possibly changing. So perhaps we should wait a bit? But I'm not totally opposed to changing it right away.

Most likely Prettier will complain about line lengths, but otherwise this looks good.

Copy link
Collaborator

@felix-hilden felix-hilden left a comment

Thanks for the quick fix!

@henrikhorluck
Copy link
Author

@henrikhorluck henrikhorluck commented Mar 23, 2022

Cool! Thanks for submitting a PR right away 👌 Although there still is a warning about it being beta and possibly changing. So perhaps we should wait a bit? But I'm not totally opposed to changing it right away.

I mean 🤷, I think it could be useful for someone to see that it's here at least, however limited or in beta it is. I think it only makes sense to either keep the documentation up to date, or not have this note in the documentation at all. I can make a new PR if they remove the support :P

@JelleZijlstra
Copy link
Collaborator

@JelleZijlstra JelleZijlstra commented Mar 23, 2022

Maybe just add "currently in beta"

@henrikhorluck
Copy link
Author

@henrikhorluck henrikhorluck commented Mar 23, 2022

Maybe just add "currently in beta"

Done! Feel free to squash the commits upon merge. (GitHub UI does not appear to reflect the change but it was pushed to the respective branch https://github.com/henrikhorluck/black/tree/patch-1)

Copy link
Collaborator

@ichard26 ichard26 left a comment

I'll just merge this one manually. Thanks for keeping the docs up to date! Congrats on your first PR to psf/black 🎉

@ichard26
Copy link
Collaborator

@ichard26 ichard26 commented Mar 23, 2022

062b549 done -- although I completely managed to forgot to attach attribution to you, sorry! >.<

@ichard26 ichard26 closed this Mar 23, 2022
@henrikhorluck henrikhorluck deleted the patch-1 branch Mar 23, 2022
@cooperlees
Copy link
Collaborator

@cooperlees cooperlees commented Mar 23, 2022

Finally. This is awesome news!

I guess this unblocks 'blackening' the standard library now! haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants