Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul diff-shades integration to fail on stable changes and preview changes for all projects #2951

Merged
merged 2 commits into from Mar 26, 2022

Conversation

ichard26
Copy link
Collaborator

@ichard26 ichard26 commented Mar 24, 2022

Description

Now PRs will run two diff-shades jobs, "preview-changes" which formats all projects with preview=True, and "assert-no-changes" which formats all projects with preview=False. The latter also fails if any changes were made.

Also the workflow_dispatch feature was dropped since it was complicating everything for little gain.

Example run: ichard26#15

Checklist - did you ...

  • Add a CHANGELOG entry if necessary? -> n/a
  • Add / update tests if necessary? -> n/a
  • Add new / update outdated documentation?

ichard26 added 2 commits Mar 23, 2022
Now PRs will run two diff-shades jobs, "preview-changes" which formats
all projects with preview=True, and "assert-no-changes" which formats
all projects with preview=False. The latter also fails if any changes
were made.

Also the workflow_dispatch feature was dropped since it was
complicating everything for little gain.
@ichard26 ichard26 added skip news Pull requests that don't need a changelog entry. C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases labels Mar 24, 2022
@ichard26
Copy link
Collaborator Author

@ichard26 ichard26 commented Mar 24, 2022

As per usual with this integration, it's impossible to test out the comment here until it's on the main branch already so please check out the linked PR :/

@ichard26 ichard26 requested a review from JelleZijlstra Mar 26, 2022
@ichard26 ichard26 merged commit f239d22 into main Mar 26, 2022
48 checks passed
@ichard26 ichard26 deleted the overhaul-diff-shades-integration branch Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants