Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strtobool function #3025

Merged
merged 3 commits into from Apr 28, 2022
Merged

Fix strtobool function #3025

merged 3 commits into from Apr 28, 2022

Conversation

defntvdm
Copy link
Contributor

@defntvdm defntvdm commented Apr 21, 2022

Description

'true' 'on' in python is 'trueon'

Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Thanks, that's embarrassing.

Since this fixes a user-facing bug, could you add a news entry?

@defntvdm
Copy link
Contributor Author

defntvdm commented Apr 28, 2022

@JelleZijlstra Did you mean to add row into CHANGELOG? I did it :)

@JelleZijlstra JelleZijlstra self-requested a review Apr 28, 2022
CHANGES.md Outdated Show resolved Hide resolved
Co-authored-by: Cooper Lees <me@cooperlees.com>
@defntvdm defntvdm requested a review from cooperlees Apr 28, 2022
Copy link
Collaborator

@cooperlees cooperlees left a comment

Thankyou for fixing this typo!

@cooperlees cooperlees merged commit c6800e0 into psf:main Apr 28, 2022
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants