Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use is_number_token insteaed of assertion #3069

Merged
merged 1 commit into from Jun 11, 2022

Conversation

MarcoGorelli
Copy link
Contributor

@MarcoGorelli MarcoGorelli commented May 11, 2022

Description

Checklist - did you ...

  • Add a CHANGELOG entry if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

Apologies if this is too trivial, the assert was just kinda bothering me

Copy link
Collaborator

@cooperlees cooperlees left a comment

Totally agree here. Thanks!

@cooperlees cooperlees added the skip news Pull requests that don't need a changelog entry. label May 11, 2022
@github-actions
Copy link

github-actions bot commented May 11, 2022

diff-shades reports zero changes comparing this PR (a630c73) to main (7f03313).


What is this? | Workflow run | diff-shades documentation

@ichard26 ichard26 self-requested a review May 20, 2022
@ichard26 ichard26 merged commit 162ecd1 into psf:main Jun 11, 2022
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants