Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for PEP 646 #3071

Merged
merged 4 commits into from May 26, 2022
Merged

Implement support for PEP 646 #3071

merged 4 commits into from May 26, 2022

Conversation

isidentical
Copy link
Collaborator

@isidentical isidentical commented May 12, 2022

Fixes #3014

@github-actions
Copy link

github-actions bot commented May 12, 2022

diff-shades reports zero changes comparing this PR (7383074) to main (fdb01f8).


What is this? | Workflow run | diff-shades documentation

@felix-hilden
Copy link
Collaborator

felix-hilden commented May 12, 2022

Yay for diff-shades! Just for an easier view, it reported this case, which seems not so good:

-    expected = df.loc[[False] * len(df.index), :]
+    expected = df.loc[[False] *len(df.index), :]

@isidentical
Copy link
Collaborator Author

isidentical commented May 12, 2022

Indeed, it is a very nice catch!

@JelleZijlstra JelleZijlstra self-assigned this May 26, 2022
@JelleZijlstra JelleZijlstra merged commit 1e55718 into psf:main May 26, 2022
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants